Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/202 : 계층별 클래스 네이밍 변경 #203

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Conversation

swa07016
Copy link
Member

🚀 개요

기존 계층별 클래스들의 이름이 역할을 명확히 반영하지 못하고 있거나
네이밍이 겹치는 경우가 있어서 네이밍을 변경하고, annotate했습니다.

🔍 변경사항

  • Facade → Service
  • Service → Adapter
  • Converter → Mapper

📝 논의사항

@swa07016 swa07016 requested review from CYY1007 and ahnsugyeong April 15, 2024 16:34
@swa07016 swa07016 self-assigned this Apr 15, 2024
@swa07016 swa07016 linked an issue Apr 15, 2024 that may be closed by this pull request
2 tasks
@CYY1007
Copy link
Member

CYY1007 commented Apr 16, 2024

고생 많으셨습니다!

Copy link
Member

@ahnsugyeong ahnsugyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 네이밍 변경하니 역할이 명확해진 것 같아서 너무 좋네요 수고하셨습니다! 👍🏻👍🏻

@CYY1007 CYY1007 merged commit 07b9bd5 into develop Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 계층별 클래스 네이밍 변경
3 participants