Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 한 주 예산 금액 조회 API 구현 #46

Merged
merged 2 commits into from
Aug 4, 2024
Merged

[FEAT] 한 주 예산 금액 조회 API 구현 #46

merged 2 commits into from
Aug 4, 2024

Conversation

ohu-star
Copy link
Contributor

@ohu-star ohu-star commented Aug 3, 2024

💡 관련 이슈

#44

📢 작업 내용

  • MonthBudgetController, MonthBudgetService에 기능 추가

🗨️ 리뷰 요구사항(선택)

✅ 체크리스트

  • 코드가 정상적으로 컴파일되나요?
  • 이슈 내용을 전부 구현했나요?
  • 작업 기간 내에 개발을 완료했나요?
  • 리뷰어를 선택했나요?
  • 라벨을 지정했나요?

@ohu-star ohu-star added the ✨ Feat 새 기능 추가 label Aug 3, 2024
@ohu-star ohu-star self-assigned this Aug 3, 2024
jimmy0524
jimmy0524 approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@jimmy0524 jimmy0524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !!

hcg0127
hcg0127 reviewed Aug 4, 2024
View reviewed changes
Copy link
Member

@hcg0127 hcg0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
한주예산이 일주일 동안의 하루예산의 합이 아니라 위에 보이는 부분입니다!
Integer 대신 List로 리턴하시면 좋을 것 같습니다.

@ohu-star
Copy link
Contributor Author

ohu-star commented Aug 4, 2024

image 한주예산이 일주일 동안의 하루예산의 합이 아니라 위에 보이는 부분입니다! Integer 대신 List로 리턴하시면 좋을 것 같습니다.

피드백 감사합니다! 수정 완료했습니다 확인 부탁드립니다 :)

hcg0127
hcg0127 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Member

@hcg0127 hcg0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 반영해주셔서 감사합니다! 수고하셨습니다 😄👍

@ohu-star ohu-star merged commit 7da8286 into develop Aug 4, 2024
@jimmy0524 jimmy0524 mentioned this pull request Aug 4, 2024
Merged
5 tasks
@ohu-star ohu-star mentioned this pull request Aug 5, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcg0127 hcg0127 hcg0127 approved these changes

@jimmy0524 jimmy0524 jimmy0524 approved these changes

@ssongmina ssongmina Awaiting requested review from ssongmina

Assignees

@ohu-star ohu-star

Labels
✨ Feat 새 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohu-star @jimmy0524 @hcg0127