Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 한달 예산 금액 조회 API 구현 #41

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

ohu-star
Copy link
Contributor

@ohu-star ohu-star commented Aug 2, 2024

💡 관련 이슈

#36

📢 작업 내용

  • MonthBudgetController, MonthBudgetService에 한달 예산 금액 조회 API 추가

🗨️ 리뷰 요구사항(선택)

✅ 체크리스트

  • 코드가 정상적으로 컴파일되나요?
  • 이슈 내용을 전부 구현했나요?
  • 작업 기간 내에 개발을 완료했나요?
  • 리뷰어를 선택했나요?
  • 라벨을 지정했나요?

@ohu-star ohu-star added the ✨ Feat 새 기능 추가 label Aug 2, 2024
@ohu-star ohu-star self-assigned this Aug 2, 2024
Copy link
Member

@hcg0127 hcg0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Contributor

@ssongmina ssongmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

Copy link
Member

@jimmy0524 jimmy0524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조회 관련 service 코드라 @transactional은 지워도 될 것 같습니다 !
클래스 상단에 @transactional(readOnly = true) 적용하고 단순 조회 메서드를 제외한 메서드에는 추가적으로 @transactional 붙이는 방법 추천합니다
수고하셨습니다 👍

@ohu-star
Copy link
Contributor Author

ohu-star commented Aug 3, 2024

조회 관련 service 코드라 @transactional은 지워도 될 것 같습니다 ! 클래스 상단에 @transactional(readOnly = true) 적용하고 단순 조회 메서드를 제외한 메서드에는 추가적으로 @transactional 붙이는 방법 추천합니다 수고하셨습니다 👍

피드백 감사합니다😄

@ohu-star ohu-star merged commit 4491de7 into develop Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 새 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants