[feat] 좋아요 전체 갯수 응답값 추가 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,7 @@ public HeartCreateResponse createHeart(final StorePostCommand storePostCommand) | |||
| validateStoreHeartCreation(user, store); | |||
| saveStoreHeart(user, store); | |||
| increaseStoreHeartCount(store); | |||
| return HeartCreateResponse.of(store.getId(), true); | |||
| return HeartCreateResponse.of(store.getId(), true, findTotalHeartCount(store)); | |||
There was a problem hiding this comment.
이 부분은 store를 매개변수로 전달해서 DTO에서 처리할 수 있지않을까요??
There was a problem hiding this comment.
store를 전달해서 dto안에서 id와 count를 꺼낼 수 있을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #82
Description ✔️
To Reviewers
응답 결과