[feat] 식당 세부 정보 조회 api #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,4 +17,9 @@ protected Store findByIdWhereDeletedIsFalse(Long id) { | |||
| return storeRepository.findByIdAndIsDeletedIsFalse(id) | |||
| .orElseThrow(() -> new NotFoundException(StoreErrorCode.STORE_NOT_FOUND)); | |||
| } | |||
|
|
|||
| protected Store findByIdWithHeartAndIsDeletedFalse(Long id) { | |||
There was a problem hiding this comment.
혹시 매개변수에 final 키워드를 붙이지 않는 이유를 여쭤봐도 될까요?
저는 final을 붙이고 있긴한데 DTO와 같은 객체의 경우 final을 사용해도 객체의 필드는 변경가능하기 때문에 이게 의미있는 사용인지 고민이라 여쭤봅니다
|
|
||
| private List<String> getImageUrlsFromStore(Store store) { | ||
| return store.getImages().stream() | ||
| .map(storeImage -> storeImage.getImageUrl()) |
There was a problem hiding this comment.
이 코드도 아래 getMenus 함수처럼 더 간결하게 변경할 수 있을 것 같습니당
.map(StoreImage::getImageUrl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #50
Description ✔️
To Reviewers
현재 응답 구조가 dto안에 dto가 있는 구조여서 dto로 받아오지 못했습니다..(되나 안 되나 앱잼 이후 확인 필요)
그래서
store, heart(일대다)를 fetch join하여 가져 온 후 식당정보, 좋아요 여부에 대한 정보 추출,
menu table 조회 후 메뉴 응답 리스트 생성,
storeImage를 조회하여 사진 리스트 생성하여 반환했습니다.
@Batch를 사용할까 하기도 했지만.. 어차피 같은 수의 쿼리가 나가게 되어 현재 로직으로 결정했습니다.