-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 족보 상세 조회 API 생성 #38
Conversation
|
||
public String getImage() { | ||
|
||
if (storeImages.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 추후 디자인에서 제공하는 default 이미지로 바꿀 예정
FetctType.LAZY 추가하고 쿼리 테스트 한 번 더 해보기 |
3f43407
to
0b5fcb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿입니다
Favorite favorite = favoriteFinder.findById(id); | ||
List<Store> stores = favorite.getFavoriteStores().stream().map(FavoriteStore::getStore).toList(); | ||
|
||
return FavoriteFindResponse.of(favorite, stores); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 이런거 favorites랑 stores를 of에 바로 넣는 편이긴 합니다 ㅋ ㅋ
List<FavoriteStoreFindResponse> stores | ||
) { | ||
|
||
public static FavoriteFindResponse of(Favorite favorite, List<Store> stores) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소하지만 여기도 final을 넣어주는 것은 어떨까요
public static FavoriteFindResponse of(Favorite favorite, List<Store> stores) { | ||
|
||
List<String> details = new ArrayList<>(); | ||
if (favorite.getDetail() != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if 안에 조건문 함수로 빼서 적절한 메서드명을 붙여주세요!
ed68a2d
to
0d93eb0
Compare
Related Issue 📌
close #27
Description ✔️
To Reviewers
Postman test 완료(아래 쿼리 실행 결과)
in
대신에array_contains
를 사용한다고 합니다. postgresql 문법에 맞춰서any
로 나가는 것 같습니다.20240711