[refac] change JPQL to Query Method

Team-Hankki · Jul 14, 2024 · 7d5d6ff · 7d5d6ff
1 parent f163519
commit 7d5d6ff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteFinder.java b/src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteFinder.java
@@ -19,10 +19,10 @@ public Favorite findById(final Long id) {
   }
 
   public List<Favorite> findAllByIds(final List<Long> ids) {
-    return favoriteRepository.findAllByIds(ids);
+    return favoriteRepository.findByIdIn(ids);
   }
 
   public List<Favorite> findAllByUserId(final Long userId) {
-    return favoriteRepository.findAllByUserId(userId);
+    return favoriteRepository.findByUserIdOrderByCreatedAtDesc(userId);
   }
 }
diff --git a/src/main/java/org/hankki/hankkiserver/domain/favorite/repository/FavoriteRepository.java b/src/main/java/org/hankki/hankkiserver/domain/favorite/repository/FavoriteRepository.java
@@ -13,9 +13,7 @@ public interface FavoriteRepository extends JpaRepository<Favorite, Long> {
   @Query("delete from Favorite f where f in :favorites")
   void deleteAll(@Param("favorites") List<Favorite> favorites);
 
-  @Query("select f from Favorite f where f.id in :favoriteId")
-  List<Favorite> findAllByIds(@Param("favoriteId") List<Long> favoriteId);
+  List<Favorite> findByIdIn(@Param("favoriteId") List<Long> favoriteId);
 
-  @Query("select f from Favorite f where f.user.id = :userId order by f.createdAt desc")
-  List<Favorite> findAllByUserId(@Param("userId") Long userId);
-}
+  List<Favorite> findByUserIdOrderByCreatedAtDesc(Long userId);
+}