feat - 배너 api 응답값에 배경색 정보 추가 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseysh
approved these changes
Nov 23, 2024
|
|
||
| private static List<String> convertToColorArray(String input) { | ||
| String[] colorArray = input.split(",\\s*"); | ||
| return Arrays.asList(colorArray); |
There was a problem hiding this comment.
P5. List의 불변성을 보장하려면 Arrays.asList보다 List.of를 사용하는 방법도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
배너 api 응답값에 배경색 정보 추가
PR 참고 사항