[Bot] Started db pattern redesign

Bot/Clash/Coc.cs

@@ -292,7 +292,7 @@ static async Task InitClanAsync()
                 }
                 catch (ClashOfClansException ex)
                 {
-                    if (ex.Error.Reason == "accessDenied")
+                    if (ex.Error.Reason.StartsWith("accessDenied"))
                     {
                         counter++;
                         continue;

Bot/Discord/Attr/RequireAdmin.cs

@@ -6,7 +6,7 @@ namespace Hyperstellar.Discord.Attr;
 
 internal sealed class RequireAdmin : PreconditionAttribute
 {
-    public override Task<PreconditionResult> CheckRequirementsAsync(IInteractionContext context, ICommandInfo commandInfo, IServiceProvider services) => Db.s_admins.Contains(context.User.Id)
+    public override Task<PreconditionResult> CheckRequirementsAsync(IInteractionContext context, ICommandInfo commandInfo, IServiceProvider services) => BotAdmin.s_admins.Contains(context.User.Id)
             ? Task.FromResult(PreconditionResult.FromSuccess())
             : Task.FromResult(PreconditionResult.FromError("Bro you're not an admin smh"));
 }

Bot/Discord/Cmds.cs

@@ -34,7 +34,7 @@ public async Task CommitAsync()
     [SlashCommand("admin", "[Owner] Makes the Discord user an admin")] // Maybe rename to addadmin
     public async Task AdminAsync(SocketGuildUser user)
     {
-        bool success = Db.AddAdmin(user.Id);
+        bool success = new BotAdmin(user.Id).Insert() == 1;
         if (success)
         {
             await RespondAsync("Success!", ephemeral: true);

Bot/Sql/BotAdmin.cs

@@ -2,10 +2,20 @@
 
 namespace Hyperstellar.Sql;
 
-internal sealed class BotAdmin(ulong id)
+internal sealed class BotAdmin(ulong id) : DbObj
 {
+    internal static readonly HashSet<ulong> s_admins = s_db.Table<BotAdmin>().Select(a => a.Id).ToHashSet();
+
+
     [PrimaryKey, NotNull]
     public ulong Id { get; set; } = id;
 
     public BotAdmin() : this(0) { }
+
+    internal override int Insert()
+    {
+        int count = base.Insert();
+        s_admins.Add(Id);
+        return count;
+    }
 }

Bot/Sql/Db.cs

@@ -4,14 +4,9 @@ namespace Hyperstellar.Sql;
 
 internal static class Db
 {
-    internal static readonly SQLiteConnection s_db = new("Hyperstellar.db");
-    internal static readonly HashSet<ulong> s_admins = s_db.Table<BotAdmin>().Select(a => a.Id).ToHashSet();
+    internal static readonly SQLiteConnection s_db = DbObj.s_db;
 
-    internal static void Commit()
-    {
-        s_db.Commit();
-        s_db.BeginTransaction();
-    }
+    internal static void Commit() => DbObj.Commit();
 
     internal static IEnumerable<Member> GetMembers() => s_db.Table<Member>();
 
@@ -35,14 +30,6 @@ internal static bool AddMembers(string[] members)
 
     internal static Alt? TryGetAlt(string altId) => s_db.Table<Alt>().FirstOrDefault(a => a.AltId == altId);
 
-    internal static bool AddAdmin(ulong id)
-    {
-        BotAdmin admin = new(id);
-        int count = s_db.Insert(admin);
-        s_admins.Add(id);
-        return count == 1;
-    }
-
     internal static CocMemberAlias? TryGetAlias(string alias)
     {
         alias = alias.ToLower();

Bot/Sql/DbObj.cs

@@ -0,0 +1,20 @@
+using System.Collections;
+using SQLite;
+
+namespace Hyperstellar.Sql;
+
+internal abstract class DbObj
+{
+    // Make this private after migration
+    internal static readonly SQLiteConnection s_db = new("Hyperstellar.db");
+
+    internal static void Commit()
+    {
+        s_db.Commit();
+        s_db.BeginTransaction();
+    }
+
+    internal static int InsertAll(IEnumerable objects) => s_db.InsertAll(objects);
+
+    internal virtual int Insert() => s_db.Insert(this);
+}