[Bot] Continue db pattern redesign & Use Ben.Demystifier #88
Annotations
1 error, 11 warnings, and 10 notices
inspect
Issues found.
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
inspect:
Bot/Clash/Coc.cs#L43
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Coc.cs(43,53)
|
inspect:
Bot/Clash/Phaser.cs#L61
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Phaser.cs(61,22)
|
inspect:
Bot/Clash/Phaser.cs#L62
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Phaser.cs(62,22)
|
inspect:
Bot/Discord/Cmds.cs#L108
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Discord/Cmds.cs(108,85)
|
inspect:
Bot/Discord/Cmds.cs#L118
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Discord/Cmds.cs(118,70)
|
inspect:
Bot/Discord/Dc.cs#L86
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Discord/Dc.cs(86,50)
|
inspect:
Bot/Discord/Dc.cs#L93
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Discord/Dc.cs(93,50)
|
inspect:
Bot/Sql/BotAdmin.cs#L7
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Sql/BotAdmin.cs(7,86)
|
inspect:
Bot/Sql/DbObj.cs#L22
"[IDE0320] Anonymous function can be made static" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Sql/DbObj.cs(22,39)
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "Bot".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
inspect:
Bot/Clash/Phaser.cs#L36
"[ForeachCanBeConvertedToQueryUsingAnotherGetEnumerator] Loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Phaser.cs(36,9)
|
inspect:
Bot/Clash/Coc.cs#L260
"[ForeachCanBePartlyConvertedToQueryUsingAnotherGetEnumerator] Part of loop's body can be converted into LINQ-expression but another 'GetEnumerator' method will be used" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Coc.cs(260,9)
|
inspect:
Bot/Clash/Phaser.cs#L45
"[ForeachCanBePartlyConvertedToQueryUsingAnotherGetEnumerator] Part of loop's body can be converted into LINQ-expression but another 'GetEnumerator' method will be used" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Phaser.cs(45,9)
|
inspect:
Bot/Clash/Coc.cs#L276
"[MemberCanBePrivate.Global] Method 'GetRaidSeasonAsync' can be made private" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Coc.cs(276,5)
|
inspect:
Bot/Clash/Phaser.cs#L246
"[MemberCanBePrivate.Global] Method 'IsDatetimeExpired' can be made private" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Phaser.cs(246,5)
|
inspect:
Bot/Clash/Coc.cs#L285
"[MoveLocalFunctionAfterJumpStatement] Put local function 'InitClanAsync' after 'return'" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Coc.cs(285,27)
|
inspect:
Bot/Clash/Coc.cs#L310
"[MoveLocalFunctionAfterJumpStatement] Put local function 'InitRaidAsync' after 'return'" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Coc.cs(310,27)
|
inspect:
Bot/Discord/Dc.cs#L64
"[MoveLocalFunctionAfterJumpStatement] Put local function 'ProcessViolator' after 'return'" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Discord/Dc.cs(64,23)
|
inspect:
Bot/Clash/Coc.cs#L126
"[MoveLocalFunctionAfterJumpStatement] Put local function 'WaitRaidAsync' after 'return'" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Coc.cs(126,27)
|
inspect:
Bot/Clash/Coc.cs#L118
"[RedundantExplicitParamsArrayCreation] Redundant explicit collection creation in argument of 'params' parameter" on /home/runner/work/Hyperstellar/Hyperstellar/Bot/Clash/Coc.cs(118,28)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
Bot
Expired
|
8.82 MB |
|