Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to embedded-hal-1.0.0 #131

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Migrate to embedded-hal-1.0.0 #131

merged 1 commit into from
Mar 16, 2024

Conversation

daehyeok
Copy link
Contributor

@daehyeok daehyeok commented Jan 23, 2024

Finally, embedded-hal v1.0 released.
Use v1.0 as a default, and make new feature embedded-hal-02 for comparability.

@daehyeok
Copy link
Contributor Author

Might time to release v0.20? #69

@TeXitoi
Copy link
Owner

TeXitoi commented Jan 23, 2024

Please, no feature to toggle the embedded-hal version. That's not good practice as feature flags should be additive.

We can point to https://github.com/rust-embedded/embedded-hal/blob/master/docs/migrating-from-0.2-to-1.0.md#embedded-hal-compat for v0.2 compatibility.

@daehyeok daehyeok force-pushed the hal branch 2 times, most recently from 75936ff to 8d16d1b Compare January 23, 2024 17:52
@daehyeok
Copy link
Contributor Author

oh.. i see. just removed v0.2..

Please, no feature to toggle the embedded-hal version. That's not good practice as feature flags should be additive.

We can point to https://github.com/rust-embedded/embedded-hal/blob/master/docs/migrating-from-0.2-to-1.0.md#embedded-hal-compat for v0.2 compatibility.

@TeXitoi TeXitoi merged commit cc21f41 into TeXitoi:master Mar 16, 2024
@TeXitoi
Copy link
Owner

TeXitoi commented Mar 16, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants