Updating main branch

.all-contributorsrc

@@ -234,6 +234,123 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "piotmag769",
+      "name": "Piotr Magiera",
+      "avatar_url": "https://avatars.githubusercontent.com/u/56825108?v=4",
+      "profile": "https://github.com/piotmag769",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "ftupas",
+      "name": "ftupas",
+      "avatar_url": "https://avatars.githubusercontent.com/u/35031356?v=4",
+      "profile": "https://github.com/ftupas",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "lambda-0x",
+      "name": "lambda-0x",
+      "avatar_url": "https://avatars.githubusercontent.com/u/87354252?v=4",
+      "profile": "https://github.com/lambda-0x",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "Tbelleng",
+      "name": "Tbelleng",
+      "avatar_url": "https://avatars.githubusercontent.com/u/117627242?v=4",
+      "profile": "https://github.com/Tbelleng",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "dic0de",
+      "name": "dic0de",
+      "avatar_url": "https://avatars.githubusercontent.com/u/37063500?v=4",
+      "profile": "https://github.com/dic0de",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "akhercha",
+      "name": "akhercha",
+      "avatar_url": "https://avatars.githubusercontent.com/u/22559023?v=4",
+      "profile": "https://github.com/akhercha",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "VictorONN",
+      "name": "VictorONN",
+      "avatar_url": "https://avatars.githubusercontent.com/u/73134512?v=4",
+      "profile": "https://github.com/VictorONN",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "kasteph",
+      "name": "kasteph",
+      "avatar_url": "https://avatars.githubusercontent.com/u/3408478?v=4",
+      "profile": "https://github.com/kasteph",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "khaeljy",
+      "name": "Khaeljy",
+      "avatar_url": "https://avatars.githubusercontent.com/u/1810456?v=4",
+      "profile": "https://github.com/khaeljy",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "JeanWoked",
+      "name": "JeanWoked",
+      "avatar_url": "https://avatars.githubusercontent.com/u/149107619?v=4",
+      "profile": "https://github.com/JeanWoked",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "vuittont60",
+      "name": "vuittont60",
+      "avatar_url": "https://avatars.githubusercontent.com/u/81072379?v=4",
+      "profile": "https://github.com/vuittont60",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "MavericksFive",
+      "name": "Arnaud Berger",
+      "avatar_url": "https://avatars.githubusercontent.com/u/95299145?v=4",
+      "profile": "https://github.com/MavericksFive",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "faytey",
+      "name": "faytey",
+      "avatar_url": "https://avatars.githubusercontent.com/u/40033608?v=4",
+      "profile": "https://github.com/faytey",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "contributorsPerLine": 7,

.devcontainer/devcontainer.json

@@ -0,0 +1,10 @@
+{
+  "name": "Satoru",
+  "image": "mcr.microsoft.com/devcontainers/base:jammy",
+  "customizations": {
+    "vscode": {
+      "extensions": ["starkware.cairo1"]
+    }
+  },
+  "postCreateCommand": "curl --proto '=https' --tlsv1.2 -sSf https://docs.swmansion.com/scarb/install.sh | sh && curl -L https://raw.githubusercontent.com/foundry-rs/starknet-foundry/master/scripts/install.sh | sh -s -- -v 0.8.3"
+}

.example.env

@@ -0,0 +1,3 @@
+PROVIDER_URL=
+ACCOUNT_PUBLIC=
+ACCOUNT_PRIVATE=

.github/semgrep-cairo-rules.yaml

@@ -0,0 +1,46 @@
+rules:  
+- id: unwrap
+  message: Use unwrap() method on $X, use expect() instead
+  languages: [cairo]
+  severity: WARNING
+  pattern: $X.unwrap()
+
+- id: division
+  message: Possible division by zero, use error_utils::check_division_by_zero to report a better error message
+  languages: [cairo]
+  severity: WARNING
+  patterns:
+    - pattern-regex: $Y / $X
+    - pattern-not-regex: error_utils::check_division_by_zero
+
+- id: reentrancy
+  message: |
+    Value mutated after call to external contract
+  severity: ERROR
+  mode: join
+  join:
+    rules:
+      - id: external-contract-declaration
+        languages: [cairo]
+        pattern: |
+          trait $SOME_CONTRACT {}
+      - id: external-call
+        languages: [cairo]
+        pattern: |
+          $SOME_CONTRACT::transfer(...);
+          ...;
+          $X::write(...);
+    on:
+      - 'external-contract-declaration.$SOME_CONTRACT == external-call.$SOME_CONTRACT'
+
+- id: unsafe-arithmetic
+  message: Call unsafe math operators on $X
+  languages: [cairo]
+  severity: ERROR
+  pattern-either:
+  - pattern: $X + $Y
+  - pattern: $X += ...
+  - pattern: $X - $Y
+  - pattern: $X -= ...
+  - pattern: $X * $Y
+  - pattern: $X *= ...

.github/workflows/build.yml

@@ -3,7 +3,7 @@ name: Build
 on: [push, pull_request]
 
 env:
-  SCARB_VERSION: 0.7.0
+  SCARB_VERSION: 2.3.1
 
 # For the moment we will use nightly versions of scarb to be able to use latest features of Cairo.
 # The installation process will be a bit different than when using non nightly versions.
@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: software-mansion/setup-scarb@v1
         with:
-          scarb-version: "0.7.0"
+          scarb-version: "2.3.1"
       # - name: Set up Scarb
       #ses: software-mansion/setup-scarb@v1
       # Install Scarb from a nightly release

.github/workflows/security.yml

@@ -9,13 +9,13 @@ jobs:
       - uses: actions/checkout@v3
       - uses: software-mansion/setup-scarb@v1
         with:
-          scarb-version: "0.7.0"
+          scarb-version: "2.3.1"
 
       - name: Install Semgrep
         run: |
-          pip install semgrep
+          pip install semgrep==1.45.0
       - name: Run Semgrep
-        run: semgrep --config https://github.com/avnu-labs/semgrep-cairo-rules/releases/download/v0.0.1/cairo-rules.yaml ./src > semgrep-output.txt
+        run: semgrep --config .github/semgrep-cairo-rules.yaml ./src > semgrep-output.txt
       - name: Save Semgrep Output as an Artifact
         uses: actions/upload-artifact@v3
         with:
@@ -32,19 +32,19 @@ jobs:
             ~/.cargo
           key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
 
-      - name: Check if Caracal is installed
-        id: check-caracal
-        run: |
-          if ! command -v caracal &> /dev/null; then
-            echo "Caracal is not installed. Installing..."
-            cargo install --git https://github.com/crytic/caracal --profile release --force
-          else
-            echo "Caracal is already installed."
-          fi
-      - name: Run Caracal
-        run: caracal detect . > caracal-output.txt
-      - name: Save Caracal Output as an Artifact
-        uses: actions/upload-artifact@v3
-        with:
-          name: caracal-cairo
-          path: caracal-output.txt
+      # - name: Check if Caracal is installed
+      #   id: check-caracal
+      #   run: |
+      #     if ! command -v caracal &> /dev/null; then
+      #       echo "Caracal is not installed. Installing..."
+      #       cargo install --git https://github.com/crytic/caracal --profile release --force
+      #     else
+      #       echo "Caracal is already installed."
+      #     fi
+      # - name: Run Caracal
+      #   run: caracal detect . > caracal-output.txt
+      # - name: Save Caracal Output as an Artifact
+      #   uses: actions/upload-artifact@v3
+      #   with:
+      #     name: caracal-cairo
+      #     path: caracal-output.txt

.github/workflows/test.yml

@@ -3,8 +3,7 @@ name: Test
 on: [push, pull_request]
 
 env:
-  SCARB_VERSION: 0.7.0
-  STARKNET_FOUNDRY_VERSION: 0.6.0
+  SCARB_VERSION: 2.3.1
 
 jobs:
   check:
@@ -13,7 +12,12 @@ jobs:
       - uses: actions/checkout@v3
       - uses: software-mansion/setup-scarb@v1
         with:
-          scarb-version: "0.7.0"
+          scarb-version: ${{ env.SCARB_VERSION }}
+      - uses: foundry-rs/setup-snfoundry@v2
+        with:
+          starknet-foundry-version: 0.10.1
+      - name: Run cairo tests
+        run: snforge test
       # - name: Set up Scarb
       #ses: software-mansion/setup-scarb@v1
       # Install Scarb from a nightly release
@@ -22,7 +26,3 @@ jobs:
       #   wget https://github.com/software-mansion/scarb-nightlies/releases/download/${NIGHTLY_DATE}/scarb-${NIGHTLY_DATE}-x86_64-unknown-linux-gnu.tar.gz
       #   tar -xvf scarb-${NIGHTLY_DATE}-x86_64-unknown-linux-gnu.tar.gz
       #   sudo mv scarb-v${SCARB_VERSION}-x86_64-unknown-linux-gnu/bin/scarb /usr/local/bin
-      - name: Install starknet foundry
-        run: curl -L https://raw.githubusercontent.com/foundry-rs/starknet-foundry/master/scripts/install.sh | sh -s -- -v ${STARKNET_FOUNDRY_VERSION}
-      - name: Run cairo tests
-        run: snforge

.gitignore

@@ -13,4 +13,6 @@ Cargo.lock
 # MSVC Windows builds of rustc generate these, which store debugging information
 *.pdb
 
-**/.DS_Store
+**/.DS_Store
+.env
+node_modules

.tool-versions

@@ -1 +1 @@
-scarb 0.7.0
+scarb 2.3.1