fix: setting dag synced state #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
approved these changes
Dec 4, 2023
kstdl
approved these changes
Dec 4, 2023
|
prnet cleaned-up successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing an issue where node we are syncing from marks us as malicious with this error:
Taraxa_N1_12042023_101626_00464.log:0x00007fbca17fa640 10c405dc… V2_GET_DAG_SYNC_PH [2023-12-04 10:23:04.234114] ERROR: Exception caught during packet processing: PacketProcessingException -> MaliciousPeer : Received multiple GetDagSyncPackets from d0dd0540… .PacketData: {"from_node_id":"d0dd0540abbd65d4b63da832afafcf7571ca1b74bfce9ac2b7d22c1a215448a07f6ce6eff0f7e54fb52c8efb8ca64bc6b03a0774f8e2bc4c01ff9e81a1783583","id":61850817,"priority":2,"receive_time":"2023-12-04 10:23:04 node local time","rlp_items_count":2,"rlp_size":0,"type":"GetDagSyncPacket"}, disconnect peer: d0dd0540abbd65d4b63da832afafcf7571ca1b74bfce9ac2b7d22c1a215448a07f6ce6eff0f7e54fb52c8efb8ca64bc6b03a0774f8e2bc4c01ff9e81a1783583
When restarting pbft syncing multiple times from the same node a check is needed if dag syncing is allowed before doing it multiple times.