Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page boiler plate #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

aomarzai
Copy link

No description provided.

Copy link

vercel bot commented May 20, 2024

Someone is attempting to deploy a commit to the Tapped Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-tapped-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 3:11pm

import Component from "../../components/ui/toggle";
const Settings = () => {
return (
<div className="min-h-screen p-8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use react-form-hooks and zod lib for making forms like. there isn't any of that code in here rn

<h1 className="text-3xl mb-8 text-center">Settings</h1>
<div className="flex flex-col items-center mb-8">
<div className="relative">
<img style={{ marginLeft: "27%" }} src="https://via.placeholder.com/150" alt="Profile" className="w-32 h-32 rounded-full object-cover" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextjs has an component that shuld be used instead of raw

</div>
</div>
<h2 className="text-xl mb-4">Preferences</h2>
<button style={{ marginLeft: "85%", width: "5rem" }} className="p-2 bg-blue-500 rounded-md text-white cursor-pointer hover:bg-blue-600 focus:outline-none focus:ring-2 focus:ring-blue-500">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these raw styles mixed with tailwindcss gives me nightmares.

also, it doesn't use the shadcn component we already have

<input type="text" id="username" name="username" defaultValue="mdotr" className="w-full p-3 bg-gray-700 rounded-md text-white focus:outline-none focus:ring-2 focus:ring-blue-500" required />
</div>
<div className="mb-6">
<label htmlFor="bio" className="block text-gray-400 mb-2">Bio</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tags and whatnot are handled by the shadcn

and components we already have

<label htmlFor="bio" className="block text-gray-400 mb-2">Bio</label>
<input type="text" id="bio" name="bio" placeholder="Enter your bio" className="w-full p-3 bg-gray-700 rounded-md text-white focus:outline-none focus:ring-2 focus:ring-blue-500" />
</div>
<div className="mb-6">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links should be instead of in nextjs

also, we already have a prebuilt city search field

@@ -0,0 +1,66 @@
export default function Component() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have a prebuilt theme toggle

Copy link
Contributor

@jonaylor89 jonaylor89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants