fix: Keep Tanker object alive in stop() until fully stopped

This prevents tanker_destroy from being called during stop(), which causes a cancel (and has triggered bugs in the past).
TankerHQ · May 3, 2021 · 4c9df2e · 4c9df2e
1 parent 205eec6
commit 4c9df2e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/tanker-bindings/src/main/kotlin/io/tanker/api/Tanker.kt b/tanker-bindings/src/main/kotlin/io/tanker/api/Tanker.kt
@@ -175,7 +175,9 @@ class Tanker(tankerOptions: TankerOptions) {
      */
     fun stop(): TankerFuture<Unit> {
         val futurePtr = lib.tanker_stop(tanker)
-        return TankerFuture(futurePtr, Unit::class.java)
+        return TankerFuture<Unit>(futurePtr, Unit::class.java).andThen(TankerCallbackWithKeepAlive(keepAlive = this) {
+            // Keep the GC from calling tanker_destroy() through the finalizer until stop() is finished
+        })
     }
 
     /**