Provide better errors for invalid identities in UpgradeIdentity

TankerHQ · Jul 22, 2021 · 499be5c · 499be5c
1 parent 951d336
commit 499be5c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/identity/generate.go b/identity/generate.go
@@ -86,7 +86,10 @@ func UpgradeIdentity(b64Identity string) (*string, error) {
 
 	_, isPrivate := identity.Get("private_encryption_key")
 	target, found := identity.Get("target")
-	if found && target == "email" && !isPrivate {
+	if !found {
+		return nil, errors.New("invalid provisional identity (missing target field)")
+	}
+	if target == "email" && !isPrivate {
 		identity.Set("target", "hashed_email")
 		value, valueFound := identity.Get("value")
 		if !valueFound {