Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only set fields to isBlurred after field blur or form submit #940

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Pascalmh
Copy link
Contributor

@Pascalmh Pascalmh commented Sep 5, 2024

this is a followup for #939

Copy link

nx-cloud bot commented Sep 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6cf946c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@940

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@940

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@940

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@940

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@940

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@940

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@940

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@940

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@940

commit: 6cf946c

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (5473bb8) to head (6cf946c).
Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   91.55%   88.57%   -2.99%     
==========================================
  Files          21       26       +5     
  Lines         900     1085     +185     
  Branches      206      269      +63     
==========================================
+ Hits          824      961     +137     
- Misses         71      115      +44     
- Partials        5        9       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment for change required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants