chore(DGHT-287): Fix Dependabot alerts #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyanwang
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
|
Storybook for this PR deployed on this github page |
|
yyanwang
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
yyanwang
commented
Dec 4, 2024
| @@ -1,4 +1,4 @@ | |||
| import { rest } from 'msw'; | |||
| import { http, HttpResponse, } from 'msw'; | |||
There was a problem hiding this comment.
rest renamed to http, and use HttpResponse to replace res parameter
yyanwang
commented
Dec 4, 2024
There was a problem hiding this comment.
I ran npm script on-msw-upgrade to regenerate service worker file after msw upgraded.
yyanwang
commented
Dec 4, 2024
| '@talend/react-cmf': minor | ||
| '@talend/scripts-publish-local': patch | ||
| '@talend/scripts-locales': patch | ||
| --- |
There was a problem hiding this comment.
For packages with major dependency upgrade, I use a minor changeset.
For packages with patch dependency upgrade, I use a patch changeset.
yyanwang
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
Gbacc
reviewed
Dec 4, 2024
| @@ -1,4 +1,4 @@ | |||
| import { rest } from 'msw'; | |||
| import { http, HttpResponse, } from 'msw'; | |||
jmfrancois
reviewed
Dec 4, 2024
| "path-to-regexp": "^3.3.0", | ||
| "path-to-regexp": "^8.2.0", |
There was a problem hiding this comment.
be sure you have tested an existing CMF application with the router 🙏
There are unit test that should be good but we never know.
By the way there are still a 6.0 in the lock file, so the security issue will stay. Do you know where it comes from ?
There was a problem hiding this comment.
Thanks for the comment!
I checked playground and vite-playground which works fine.
version 6 comes from multiple packages but 6.3.0 is a "safe" version :
=> Found "[email protected]"
info Has been hoisted to "path-to-regexp"
info Reasons this module exists
- "workspace-aggregator-8113ffd5-c4b4-4412-9f5c-5bcfa979cb8e" depends on it
- Hoisted from "_project_#@talend#ui-playground-vite#vite-plugin-mock#path-to-regexp"
- Hoisted from "_project_#@talend#react-containers#msw#path-to-regexp"
- Hoisted from "_project_#@talend#react-bootstrap#sinon#nise#path-to-regexp"
yyanwang
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
yyanwang
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
jmfrancois
approved these changes
Dec 9, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Resolve Dependabot alerts in the project.
This PR will fix:
https://github.com/Talend/ui/security/dependabot/242
https://github.com/Talend/ui/security/dependabot/241
https://github.com/Talend/ui/security/dependabot/237
https://github.com/Talend/ui/security/dependabot/216
https://github.com/Talend/ui/security/dependabot/215
https://github.com/Talend/ui/security/dependabot/245
Dependencies upgraded:
"cross-spawn": "^7.0.3" => "^7.0.6"
"path-to-regexp": "^3.30" => "^8.2.0"
"msw": "^1.3.5" => "^2.6.6"
"msw-storybook-addon": "^1.10.0" => "^2.0.4"
"browser-sync": "^2.29.3" => "^3.0.3"
Changes:
path-to-regexpin matchPath.js. Test passed after change.mswin AboutDialog container's story and storybook configuration. Regenerate msw service worker. Storybook of react-containers package works fine after this change.msw-storybook-addonneed to be upgraded from 1.x to 2.x because we upgraded msw.Changeset:
For packages with major dependency upgrade, I use a minor changeset.
For packages with patch dependency upgrade, I use a patch changeset.
What is the chosen solution to this problem?
Please check if the PR fulfills these requirements
yarn changesetto a request a release from the CI if wanted.[ ] This PR introduces a breaking change