Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @floating-ui/react from 0.24.8 to 0.26.28 #5458

Merged
merged 6 commits into from
Dec 9, 2024
Merged

chore(deps): bump @floating-ui/react from 0.24.8 to 0.26.28 #5458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd0d01d
chore(deps): bump @floating-ui/react from 0.24.8 to 0.26.28
dependabot[bot] Nov 18, 2024
737d2d5
test: update snap
jmfrancois Dec 9, 2024
8630031
Merge branch 'master' into dependabot/npm_and_yarn/floating-ui/react-…
jmfrancois Dec 9, 2024
fb882ab
test: update
jmfrancois Dec 9, 2024
6729df8
test: update
jmfrancois Dec 9, 2024
c5d6764
chore: add changeset
jmfrancois Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/sweet-shoes-carry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@talend/design-system': patch
'@talend/react-components': patch
---

fix: update floating-ui lib
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"lint": "cross-env WORKSPACE_RUN_FAIL=no-bail talend-yarn-workspace run lint",
"lint-merge-report": "talend-scripts lint-merge-report",
"test": "cross-env TZ=UTC talend-yarn-workspace run test --silent",
"test:update": "cross-env TZ=UTC yarn workspaces run test --silent -u",
"test:update": "cross-env TZ=UTC talend-yarn-workspace run test --silent -u",
"test:cov": "cross-env TZ=UTC talend-yarn-workspace run test:cov",
"test:demo": "talend-yarn-workspace run test:demo",
"test:cron": "talend-yarn-workspace run test:cron",
Expand Down
11 changes: 6 additions & 5 deletions packages/components/src/List/ListComposition/ColumnChooser/ColumnChooser.component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,19 @@ describe('ColumnChooser', () => {
};
});

it('should render column chooser component', () => {
it('should render column chooser component', async () => {
// when
render(
<ListContext.Provider value={defaultContext}>
<ColumnChooser id="myColumnChooser" />
<ColumnChooser id="myColumnChooser" data-testid="chooser" />
</ListContext.Provider>,
);

// then
expect(screen.getByRole('button')).toBeVisible();
act(() => screen.getByRole('button').focus()); // trigger the tooltip
expect(screen.getByText('Open the column chooser')).toBeVisible();
const btn = screen.getByLabelText('Open the column chooser');
expect(btn).toBeVisible();
await userEvent.hover(btn);
expect(screen.getByRole('tooltip')).toHaveTextContent('Open the column chooser');
});

it('should update columns', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/List/ListComposition/DisplayMode/ListDisplayMode.component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('List DisplayMode', () => {
);

// then
act(() => screen.getAllByRole('button')[0].focus());
await userEvent.hover(screen.getAllByRole('button')[0]);
expect(screen.getByText('Set Table as current display mode.')).toBeVisible();
});

Expand Down
4 changes: 4 additions & 0 deletions ...s/components/src/VirtualizedList/CellQualityBar/__snapshots__/CellQualityBar.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ exports[`CellQualityBar should render a valid quality bar 1`] = `
>
<div
class="theme-container"
data-floating-ui-focusable=""
id="id-42"
role="tooltip"
style="display: none; position: absolute; left: 0px; top: 0px; transform: translate(0px, 0px);"
Expand Down Expand Up @@ -111,6 +112,7 @@ exports[`CellQualityBar should render a valid quality bar 1`] = `
>
<div
class="theme-container"
data-floating-ui-focusable=""
id="id-42"
role="tooltip"
style="display: none; position: absolute; left: 0px; top: 0px; transform: translate(0px, 0px);"
Expand Down Expand Up @@ -147,6 +149,7 @@ exports[`CellQualityBar should render a valid quality bar 1`] = `
>
<div
class="theme-container"
data-floating-ui-focusable=""
id="id-42"
role="tooltip"
style="display: none; position: absolute; left: 0px; top: 0px; transform: translate(0px, 0px);"
Expand Down Expand Up @@ -183,6 +186,7 @@ exports[`CellQualityBar should render a valid quality bar 1`] = `
>
<div
class="theme-container"
data-floating-ui-focusable=""
id="id-42"
role="tooltip"
style="display: none; position: absolute; left: 0px; top: 0px; transform: translate(0px, 0px);"
Expand Down
2 changes: 1 addition & 1 deletion packages/design-system/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"access": "public"
},
"dependencies": {
"@floating-ui/react": "^0.24.8",
"@floating-ui/react": "^0.26.28",
"@talend/assets-api": "^1.5.1",
"@talend/design-tokens": "^3.4.3",
"@talend/utils": "^3.2.3",
Expand Down
2 changes: 2 additions & 0 deletions packages/design-system/src/components/Badge/__snapshots__/Badge.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ exports[`Badge should render a11y html 1`] = `
aria-label="Select item"
aria-orientation="vertical"
class="theme-dropdownShell"
data-floating-ui-focusable=""
data-test="dropdown.menu"
data-testid="dropdown.menu"
role="menu"
Expand Down Expand Up @@ -193,6 +194,7 @@ exports[`Badge should render a11y html 1`] = `
aria-label="Select item"
aria-orientation="vertical"
class="theme-dropdownShell"
data-floating-ui-focusable=""
data-test="dropdown.menu"
data-testid="dropdown.menu"
role="menu"
Expand Down
1 change: 1 addition & 0 deletions packages/design-system/src/components/Breadcrumbs/__snapshots__/Breadcrumbs.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ exports[`Breadcrumbs should render a11y html 1`] = `
aria-label="Collapsed links"
aria-orientation="vertical"
class="theme-dropdownShell"
data-floating-ui-focusable=""
data-test="dropdown.menu"
data-testid="dropdown.menu"
role="menu"
Expand Down
1 change: 1 addition & 0 deletions packages/design-system/src/components/Dropdown/__snapshots__/Dropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ exports[`Dropdown should render a11y html 1`] = `
aria-label="Custom menu"
aria-orientation="vertical"
class="theme-dropdownShell"
data-floating-ui-focusable=""
data-test="dropdown.menu"
data-testid="dropdown.menu"
role="menu"
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2047,21 +2047,21 @@
"@floating-ui/core" "^1.6.0"
"@floating-ui/utils" "^0.2.8"

"@floating-ui/react-dom@^2.0.0", "@floating-ui/react-dom@^2.0.1":
"@floating-ui/react-dom@^2.0.0", "@floating-ui/react-dom@^2.1.2":
version "2.1.2"
resolved "https://registry.yarnpkg.com/@floating-ui/react-dom/-/react-dom-2.1.2.tgz#a1349bbf6a0e5cb5ded55d023766f20a4d439a31"
integrity sha512-06okr5cgPzMNBy+Ycse2A6udMi4bqwW/zgBF/rwjcNqWkyr82Mcg8b0vjX8OJpZFy/FKjJmw6wV7t44kK6kW7A==
dependencies:
"@floating-ui/dom" "^1.0.0"

"@floating-ui/react@^0.24.8":
version "0.24.8"
resolved "https://registry.yarnpkg.com/@floating-ui/react/-/react-0.24.8.tgz#e079e2836990be3fce9665ab509360a5447251a1"
integrity sha512-AuYeDoaR8jtUlUXtZ1IJ/6jtBkGnSpJXbGNzokBL87VDJ8opMq1Bgrc0szhK482ReQY6KZsMoZCVSb4xwalkBA==
"@floating-ui/react@^0.26.28":
version "0.26.28"
resolved "https://registry.yarnpkg.com/@floating-ui/react/-/react-0.26.28.tgz#93f44ebaeb02409312e9df9507e83aab4a8c0dc7"
integrity sha512-yORQuuAtVpiRjpMhdc0wJj06b9JFjrYF4qp96j++v2NBpbi6SEGF7donUJ3TMieerQ6qVkAv1tgr7L4r5roTqw==
dependencies:
"@floating-ui/react-dom" "^2.0.1"
aria-hidden "^1.2.3"
tabbable "^6.0.1"
"@floating-ui/react-dom" "^2.1.2"
"@floating-ui/utils" "^0.2.8"
tabbable "^6.0.0"

"@floating-ui/utils@^0.2.8":
version "0.2.8"
Expand Down Expand Up @@ -6107,7 +6107,7 @@ [email protected]:
resolved "https://registry.yarnpkg.com/argv/-/argv-0.0.2.tgz#ecbd16f8949b157183711b1bda334f37840185ab"
integrity sha512-dEamhpPEwRUBpLNHeuCm/v+g0anFByHahxodVO/BbAarHVBBg2MccCwf9K+o1Pof+2btdnkJelYVUWjW/VrATw==

aria-hidden@^1.1.1, aria-hidden@^1.2.3:
aria-hidden@^1.1.1:
version "1.2.4"
resolved "https://registry.yarnpkg.com/aria-hidden/-/aria-hidden-1.2.4.tgz#b78e383fdbc04d05762c78b4a25a501e736c4522"
integrity sha512-y+CcFFwelSXpLZk/7fMB2mUbGtX9lKycf1MWJ7CaTIERyitVlyQx6C+sxcROU2BAJ24OiZyK+8wj2i8AlBoS3A==
Expand Down Expand Up @@ -18398,7 +18398,7 @@ synckit@^0.9.0, synckit@^0.9.1:
"@pkgr/core" "^0.1.0"
tslib "^2.6.2"

tabbable@^6.0.1:
tabbable@^6.0.0:
version "6.2.0"
resolved "https://registry.yarnpkg.com/tabbable/-/tabbable-6.2.0.tgz#732fb62bc0175cfcec257330be187dcfba1f3b97"
integrity sha512-Cat63mxsVJlzYvN51JmVXIgNoUokrIaT2zLclCXjRd8boZ0004U4KCs/sToJ75C6sdlByWxpYnb5Boif1VSFew==
Expand Down
Loading