Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): regexp #4924

Merged
merged 8 commits into from
Nov 29, 2023
Merged

fix(security): regexp #4924

merged 8 commits into from
Nov 29, 2023

Conversation

jmfrancois
Copy link
Collaborator

@jmfrancois jmfrancois commented Oct 6, 2023 •
edited by aamalric-talend
Loading

What is the problem this PR is trying to solve?

We have some security alter on some regexp

What is the chosen solution to this problem?

fixes #4925

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 6, 2023 07:41 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 6, 2023 07:46 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 6, 2023 07:46 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 6, 2023 07:46 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

4924

:octocat: Demo is available here

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 6, 2023 08:10 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 6, 2023 09:12 — with GitHub Actions Inactive
@aamalric-talend aamalric-talend force-pushed the jmfrancois/fix/security-regex branch from c5c4b51 to eb0c582 Compare November 28, 2023 10:08
@aamalric-talend aamalric-talend marked this pull request as ready for review November 28, 2023 13:26
@aamalric-talend aamalric-talend force-pushed the jmfrancois/fix/security-regex branch from e7079f7 to 361cb60 Compare November 28, 2023 15:45
@aamalric-talend aamalric-talend force-pushed the jmfrancois/fix/security-regex branch from fbac623 to f13af35 Compare November 28, 2023 21:32
@github-actions GitHub Actions
Copy link
Contributor

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.19% (1271/1425) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 90.39% (5607/6203) 81.62% (3221/3946) 87.63% (1418/1618)
containers Coverage: 84%
 83.53% (1385/1658) 74.67% (687/920) 75.17% (327/435)
dataviz Coverage: 85%
 85.6% (321/375) 66.66% (160/240) 75.64% (118/156)
design-system Coverage: 67%
 66.59% (899/1350) 48.72% (439/901) 53.18% (192/361)
faceted-search Coverage: 85%
 85.03% (693/815) 76.63% (269/351) 81.75% (242/296)
flow-designer Coverage: 70%
 70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
 85.67% (1675/1955) 75.29% (908/1206) 84.58% (472/558)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (62/62) 90.9% (10/11) 100% (16/16)

@aamalric-talend aamalric-talend merged commit 795a12e into master Nov 29, 2023
12 checks passed
@aamalric-talend aamalric-talend deleted the jmfrancois/fix/security-regex branch November 29, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuchet mhuchet mhuchet approved these changes

@romainseb romainseb romainseb approved these changes

Assignees

@aamalric-talend aamalric-talend

Labels
need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert
5 participants
@jmfrancois @smouillour @romainseb @mhuchet @aamalric-talend