Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataviz): allow to build custom legend #4298

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

romainseb
Copy link
Contributor

@romainseb romainseb commented Aug 30, 2022

What is the problem this PR is trying to solve?
CleanShot 2022-08-30 at 17 08 33@2x

It's a bit broken if we try to insert JSX

What is the chosen solution to this problem?
Use the Design System
CleanShot 2022-08-30 at 17 25 36@2x

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@romainseb romainseb self-assigned this Aug 30, 2022
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:25 Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:25 Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:25 Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:25 Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:26 Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:26 Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:26 Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe August 30, 2022 15:26 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2022

Size Change: +471 B (0%)

Total Size: 12.2 MB

Filename Size Change
./packages/dataviz/dist/TalendReactDataviz.js 320 kB +174 B (0%)
./packages/dataviz/dist/TalendReactDataviz.min.js 61.5 kB +121 B (0%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.25 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.34 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 39.7 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 604 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 6.94 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 623 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 121 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.27 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.4 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 537 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.33 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 106 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.37 kB 0 B
./packages/components/dist/TalendReactComponents.css 356 kB 0 B
./packages/components/dist/TalendReactComponents.js 2.83 MB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.17 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 183 kB 0 B
./packages/components/dist/TalendReactComponents.min.js 635 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.25 kB 0 B
./packages/containers/dist/TalendReactContainers.css 2.93 kB 0 B
./packages/containers/dist/TalendReactContainers.js 435 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.56 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.73 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 88.8 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.61 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.css 20.5 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js 177 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 1.39 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.css 7.58 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 40.2 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 1.43 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 24.3 kB +94 B (0%)
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.16 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 8.81 kB +82 B (+1%)
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 154 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js 1.08 MB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.57 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.css 94.6 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js 232 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.61 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 39 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 34.5 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 36.2 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 28.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 31.9 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 363 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.55 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 14.8 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 94.2 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.6 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 49.5 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.08 kB 0 B
./packages/forms/dist/mode-json.js 48.3 kB 0 B
./packages/forms/dist/mode-python.js 4.61 kB 0 B
./packages/forms/dist/mode-sql.js 1.83 kB 0 B
./packages/forms/dist/snippets-json.js 131 B 0 B
./packages/forms/dist/snippets-python.js 3.84 kB 0 B
./packages/forms/dist/snippets-sql.js 972 B 0 B
./packages/forms/dist/TalendReactForms.css 34.8 kB 0 B
./packages/forms/dist/TalendReactForms.js 736 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.69 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 11.7 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 210 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.73 kB 0 B
./packages/forms/dist/theme-chrome.js 2.71 kB 0 B
./packages/http/dist/TalendHttp.js 23.1 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 3.98 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 24.6 kB 0 B
./packages/icons/dist/react.esm.js 531 kB 0 B
./packages/icons/dist/react.js 571 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 16.8 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 643 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 554 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 13.4 kB 0 B
./packages/jsfc/dist/index.js 86.4 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 92.2 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 20.6 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.js 24.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 962 B 0 B
./packages/stepper/dist/TalendReactStepper.min.js 4.05 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 988 B 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 10.4 kB 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.53 kB 0 B
./packages/theme/dist/bootstrap.css 149 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

@github-actions
Copy link
Contributor

4298

:octocat: Demo is available here

@romainseb romainseb merged commit 6e850c4 into master Aug 31, 2022
@romainseb romainseb deleted the sromain/dataviz/custom-labels branch August 31, 2022 08:52
@romainseb romainseb temporarily deployed to pull_request_unsafe August 31, 2022 08:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants