Skip to content

Commit

Permalink
set hoist to false and solve dependency issues
Browse files Browse the repository at this point in the history
  • Loading branch information
smouillour committed Oct 18, 2023
1 parent 0e2b052 commit b1512ed
Show file tree
Hide file tree
Showing 14 changed files with 1,638 additions and 268 deletions.
16 changes: 9 additions & 7 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
#shamefully-hoist=true
#node-linker=hoisted
#symlink=false
prefer-workspace-packages=true
#link-workspace-packages=false
#link-workspace-packages=deep
#strict-peer-dependencies=true
#public-hoist-pattern[]=*storybook*

#https://pnpm.io/blog/2020/10/17/node-modules-configuration-options-with-pnpm#plugnplay-the-strictest-configuration
hoist=false
# hoist-pattern[]=autoprefixer
# hoist-pattern[]=postcss-loader
# hoist-pattern[]=postcss
public-hoist-pattern[]=autoprefixer
#public-hoist-pattern[]=*types*
#public-hoist-pattern[]=*eslint*
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"@changesets/cli": "^2.26.2",
"@talend/scripts-config-prettier": "^12.0.0",
"@talend/scripts-config-babel": "^13.0.0",
"@types/react": "^17.0.2",
"@types/react-dom": "^17.0.20",
"cross-env": "^7.0.3",
"cross-spawn": "^7.0.3",
"eslint": "^7.32.0",
Expand All @@ -13,9 +11,7 @@
"lint-staged": "^13.3.0",
"prettier": "^3.0.3",
"rimraf": "^3.0.2",
"terser-webpack-plugin": "^5.3.9",
"typescript": "^5.0.4",
"webpack": "^5.73.0"
"typescript": "^5.0.4"
},
"scripts": {
"postinstall": "pnpm -r --stream run build:lib",
Expand Down
4 changes: 4 additions & 0 deletions packages/a11y/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@
"@talend/scripts-config-typescript": "^11.1.0",
"@testing-library/react": "^12.1.5",
"@testing-library/user-event": "^13.5.0",
"@types/date-fns": "^0.0.2",
"@types/jest": "^29.5.5",
"@types/react": "^17.0.65",
"@types/react-dom": "^17.0.20",
"date-fns": "^1.30.1",
"react": "^17.0.2",
"react-dom": "^17.0.2"
},
Expand Down
1 change: 1 addition & 0 deletions packages/dataviz/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"@types/cypress": "^1.1.3",
"@types/geojson": "^7946.0.10",
"@types/lodash": "^4.14.198",
"@types/node": "^6.14.13",
"@types/react": "^17.0.65",
"@types/topojson-client": "^3.1.2",
"@types/topojson-specification": "^1.0.3",
Expand Down
1 change: 1 addition & 0 deletions packages/design-tokens/jest.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
module.exports = {
testEnvironment: 'jest-environment-jsdom',
testRegex: '(/__tests__/.*|src/|scripts/).*\\.test.(js|ts|tsx)$',
};
4 changes: 3 additions & 1 deletion packages/design-tokens/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
"@talend/babel-plugin-import-from-index": "^1.5.1",
"@talend/babel-plugin-assets-api": "^1.1.0",
"jest": "^29.7.0",
"typeface-source-sans-pro": "^1.1.13"
"jest-environment-jsdom": "^29.7.0",
"typeface-source-sans-pro": "^1.1.13",
"webpack": "^5.88.2"
},
"dependencies": {}
}
2 changes: 2 additions & 0 deletions packages/http/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"@talend/scripts-config-babel": "^13.0.0",
"@talend/scripts-config-react-webpack": "^16.0.0",
"@talend/scripts-config-typescript": "^11.1.0",
"@types/jest": "^29.5.5",
"@types/node-fetch": "^2.6.6",
"fetch-mock": "^9.11.0",
"node-fetch": "^2.7.0",
"react": "^17.0.2",
Expand Down
1 change: 1 addition & 0 deletions packages/icons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"string-replace-loader": "^2.3.0",
"style-loader": "^1.3.0",
"svgo": "^1.3.2",
"url-loader": "^4.1.1",
"webfonts-loader": "^8.0.1",
"webpack": "^5.88.2",
"webpack-cli": "^4.10.0"
Expand Down
3 changes: 2 additions & 1 deletion packages/jsfc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
"@types/chai": "^3.5.2",
"@types/node": "^6.14.13",
"json-refs": "^3.0.15",
"rimraf": "^3.0.2"
"rimraf": "^3.0.2",
"webpack": "^5.88.2"
},
"dependencies": {
"objectpath": "^1.2.2",
Expand Down
12 changes: 11 additions & 1 deletion packages/storybook-docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@
"@talend/scripts-config-babel": "^13.0.0",
"@talend/scripts-config-storybook-lib": "^5.0.0",
"@talend/scripts-config-typescript": "^11.1.0",
"@types/node": "^6.14.13"
"@types/node": "^6.14.13",
"@types/react": "^17.0.65",
"@types/react-dom": "^17.0.20",
"css-loader": "^4.3.0",
"mini-css-extract-plugin": "^2.7.6",
"postcss-loader": "^7.3.3",
"resolve-url-loader": "^5.0.0",
"sass": "^1.68.0",
"sass-loader": "^13.3.2",
"webpack": "^5.88.2",
"webpack-cli": "^4.10.0"
}
}
Loading

0 comments on commit b1512ed

Please sign in to comment.