chore(TDP-12538): always show tooltip on faceted badge overlay (#4903)

Talend · Sep 25, 2023 · 08b8257 · 08b8257
1 parent 3fc8e01
commit 08b8257
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 9 deletions.
diff --git a/.changeset/dirty-geckos-eat.md b/.changeset/dirty-geckos-eat.md
@@ -0,0 +1,5 @@
+---
+'@talend/react-faceted-search': minor
+---
+
+chore(TDP-12538): always show tooltip on faceted badge overlay
diff --git a/...ted-search/src/components/Badges/BadgeDate/__snapshots__/BadgeDate.component.test.js.snap b/...ted-search/src/components/Badges/BadgeDate/__snapshots__/BadgeDate.component.test.js.snap
@@ -43,6 +43,7 @@ exports[`BadgeDate should render a default badge 1`] = `
       class="tc-badge-faceted-overlay theme-tc-badge-faceted-overlay"
     >
       <button
+        aria-describedby="42"
         aria-label="2011-10-01"
         class="btn btn-link"
         id="myId-badge-date-action-overlay"

diff --git a/...arch/src/components/Badges/BadgeFaceted/__snapshots__/BadgeFaceted.component.test.js.snap b/...arch/src/components/Badges/BadgeFaceted/__snapshots__/BadgeFaceted.component.test.js.snap
@@ -43,6 +43,7 @@ exports[`BadgeFaceted should render the html output by default 1`] = `
       class="tc-badge-faceted-overlay theme-tc-badge-faceted-overlay"
     >
       <button
+        aria-describedby="42"
         aria-label="All"
         class="btn btn-link"
         id="my-id-action-overlay"

diff --git a/...search/src/components/Badges/BadgeNumber/__snapshots__/BadgeNumber.component.test.js.snap b/...search/src/components/Badges/BadgeNumber/__snapshots__/BadgeNumber.component.test.js.snap
@@ -43,6 +43,7 @@ exports[`BadgeNumber should mount a default badge 1`] = `
       class="tc-badge-faceted-overlay theme-tc-badge-faceted-overlay"
     >
       <button
+        aria-describedby="42"
         aria-label="All"
         class="btn btn-link"
         id="myId-badge-number-action-overlay"

diff --git a/packages/faceted-search/src/components/Badges/BadgeOverlay/BadgeOverlay.component.js b/packages/faceted-search/src/components/Badges/BadgeOverlay/BadgeOverlay.component.js
@@ -88,17 +88,11 @@ const BadgeOverlay = ({
 		</Button>
 	);
 
-	const buttonToRender = iconName ? (
-		<TooltipTrigger label={label} tooltipPlacement="top">
-			{button}
-		</TooltipTrigger>
-	) : (
-		button
-	);
-
 	return (
 		<div className={className}>
-			{buttonToRender}
+			<TooltipTrigger label={label} tooltipPlacement="top">
+				{button}
+			</TooltipTrigger>
 
 			<Overlay
 				id={`${id}-overlay`}

diff --git a/...arch/src/components/Badges/BadgeOverlay/__snapshots__/BadgeOverlay.component.test.js.snap b/...arch/src/components/Badges/BadgeOverlay/__snapshots__/BadgeOverlay.component.test.js.snap
@@ -3,6 +3,7 @@
 exports[`BadgeOverlay should render the html output in the default state 1`] = `
 <div>
   <button
+    aria-describedby="42"
     aria-label="my label"
     class="btn btn-link"
     id="my-id-action-overlay"

diff --git a/...search/src/components/Badges/BadgeSlider/__snapshots__/BadgeSlider.component.test.js.snap b/...search/src/components/Badges/BadgeSlider/__snapshots__/BadgeSlider.component.test.js.snap
@@ -43,6 +43,7 @@ exports[`BadgeSlider should mount a default badge 1`] = `
       class="tc-badge-faceted-overlay theme-tc-badge-faceted-overlay"
     >
       <button
+        aria-describedby="42"
         aria-label="0"
         class="btn btn-link"
         id="myId-badge-slider-action-overlay"

diff --git a/...ted-search/src/components/Badges/BadgeText/__snapshots__/BadgeText.component.test.js.snap b/...ted-search/src/components/Badges/BadgeText/__snapshots__/BadgeText.component.test.js.snap
@@ -43,6 +43,7 @@ exports[`BadgeText should mount a default badge 1`] = `
       class="tc-badge-faceted-overlay theme-tc-badge-faceted-overlay"
     >
       <button
+        aria-describedby="42"
         aria-label="All"
         class="btn btn-link"
         id="myId-badge-text-action-overlay"

diff --git a/...aceted-search/src/components/BasicSearch/__snapshots__/BasicSearch.component.test.js.snap b/...aceted-search/src/components/BasicSearch/__snapshots__/BasicSearch.component.test.js.snap
@@ -92,6 +92,7 @@ exports[`BasicSearch should render the default html output with no badges 1`] =
           class="tc-badge-faceted-overlay theme-tc-badge-faceted-overlay"
         >
           <button
+            aria-describedby="42"
             aria-label="hello"
             class="btn btn-link"
             id="name-7bc9bd07-3b46-4b8c-a406-a08b6263de5b-badge-text-action-overlay"