Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic tutorials #118

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pratclot
Copy link

Hi, I saw PR-80 was made a bit untimely, but I liked very much the setRectSupplierFromView() made by Oliver there.

Maybe it is possible to add some kind of a smart processing for shapes?

@pratclot
Copy link
Author

Hi! I added some more changes to the library. There are basically 4 things in this PR now.

  • ability to let the library construct the shape based on the target's view (will provide a RoundedRectangle)
  • ability to pass click to highlighted area while blocking all other regions of the overlay. It is also possible to just disable the clicking on the target throught the target builder
  • ability to specify simple horizontal captions via target builder. The library will place them above or under the highlighted area according to the desired margins
  • added some intermediary SpotlightCoordinator interface. Basically, it holds the current Spotlight instance. The main purpose is to be able to walk inside the app during the active Spotlight (by utilizing target clicking ability). There is a new example which demonstrates how 2 fragments may use this shared Spotlight instance. Their Activity is assigned the SpotlightCoordinator role

Hope that helps someone someday! Thanks.

@pratclot
Copy link
Author

pratclot commented Apr 1, 2021

Today also completed work on the RecyclerView example.

@pratclot pratclot changed the title add a DynamicShape Add support for dynamic tutorials Apr 1, 2021
@FitApps7
Copy link

@pratclot how I can make caption like this?

device-2021-07-18-100723.mp4

@Nasib555
Copy link

@pratclot You should add code examples about how to achieve the abilities you've added in this PR.

@pratclot
Copy link
Author

@Nasib555 actually, there are two new Activities already. Please check if they work for you.

Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants