Support user-assigned country codes, take two. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 17, 2017 15:21
Added following methods to class StandardOrUserAssignedCountryCode: getStandardCountryCode() getUserAssignedCountryCode() isStandard() isUserAssigned()
…ent check in StandardOrUserAssignedCountryCode constructor.
derekmahar
force-pushed
the
userAssigned2
branch
from
652aba2 to
2fb3beb
Compare
|
@TakahikoKawasaki, have you considered accepting my implementation of user-assigned country codes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takahiko, this is my second solution to issue #25. Unlike my first attempt, this implementation follows the open-closed principle and shouldn't break existing client code.
Note that I haven't yet added javadoc comments to the classes and methods.