Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simplified Chinese translation #24

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Add Simplified Chinese translation #24

merged 3 commits into from
Jul 24, 2024

Conversation

OrO-c
Copy link
Contributor

@OrO-c OrO-c commented Jul 24, 2024

No description provided.

Copy link

github-actions bot commented Jul 24, 2024

Copy link
Owner

@Taewan-P Taewan-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution!

@Taewan-P Taewan-P added the translation Translation updates label Jul 24, 2024
@Taewan-P Taewan-P merged commit d72de38 into Taewan-P:main Jul 24, 2024
3 checks passed
@OrO-c OrO-c deleted the patch-1 branch July 24, 2024 10:36
@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 24, 2024

I just installed the auto-build apk, why is it not displaying Simplified Chinese properly on my device, and still in English?
Screenshot_20240724190716
Screenshot_20240724190720

@Taewan-P
Copy link
Owner

Check for per-app language setting in your phone setting, or in your app information page. You should be able to change it there.
If your phone uses Android 12 or below, it is not currently supported.

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 24, 2024

My phone language is now Simplified Chinese, but the problem is not resolved
The "所有语言" in the screenshot means all languages, but there is no option for Simplified Chinese.
Screenshot_20240724192134

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 24, 2024

And I'm on Android 13.

@Taewan-P
Copy link
Owner

image

From my emulator, after selecting Chinese, choosing the second one on the picture above changes the app language. (Don't know how to read it) Isn't this simplified Chinese?

image

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 24, 2024

Maybe we're not installing the same apk?
Sorry, it should be my mistake.
My apk was downloaded from this page
https://github.com/Taewan-P/gpt_mobile/actions/runs/10074482557

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 25, 2024

image From my emulator, after selecting Chinese, choosing the second one on the picture above changes the app language. (Don't know how to read it) Isn't this simplified Chinese? image

Yes.

@Taewan-P
Copy link
Owner

Is it solved?

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 25, 2024

Is it solved?

No

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 25, 2024

Can you send me a copy of the apk file you installed?
I think it's the access channel, you probably built it yourself with the source code, while I downloaded the auto-built apk

@Taewan-P
Copy link
Owner

Looking at the workflow logs, it built the wrong source code. It should be cloning your forked version, but pulled the origin code. That's why it is not normally applied.

I can't access to my computer right now, so you should try fetching upstream of the fork or pull my repo main branch. Then, try building it on your computer & install.

@Taewan-P
Copy link
Owner

If you can't build it on your own, I might have time to upload it tonight

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 25, 2024

Looking at the workflow logs, it built the wrong source code. It should be cloning your forked version, but pulled the origin code. That's why it is not normally applied.

I can't access to my computer right now, so you should try fetching upstream of the fork or pull my repo main branch. Then, try building it on your computer & install.

Okay

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 25, 2024

If you can't build it on your own, I might have time to upload it tonight

Thank you

@Taewan-P
Copy link
Owner

Taewan-P commented Jul 25, 2024

Try this: app-debug.apk.zip

@OrO-c
Copy link
Contributor Author

OrO-c commented Jul 25, 2024

Try this: app-debug.apk.zip

It’s solved.Thanks!Screenshot_20240725211113.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants