Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add functionality to delete entire thread #3410

Merged
merged 6 commits into from
Nov 13, 2024
Merged

feat(ui): add functionality to delete entire thread #3410

merged 6 commits into from
Nov 13, 2024

Conversation

liangfung
Copy link
Collaborator

Changes

  1. Support for deleting entire thread
  2. Add global 404 page for handling redirects to non-existent threads and other invalid URLs.

Screen record

https://jam.dev/c/c33d9233-b301-46ce-a747-4e818803cbcb

Screenshot

image
image

@liangfung liangfung force-pushed the feat-ui-delete-thread branch from 5ec8a0b to 3802f76 Compare November 13, 2024 05:19
@liangfung liangfung changed the title feat(WIP): add functionality to delete entire thread feat(ui): add functionality to delete entire thread Nov 13, 2024
@liangfung liangfung marked this pull request as ready for review November 13, 2024 06:28
@wsxiaoys wsxiaoys enabled auto-merge (squash) November 13, 2024 06:31
@liangfung liangfung requested a review from wsxiaoys November 13, 2024 06:32
@wsxiaoys wsxiaoys merged commit 5c14645 into main Nov 13, 2024
4 checks passed
@wsxiaoys wsxiaoys deleted the feat-ui-delete-thread branch November 13, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsxiaoys wsxiaoys Awaiting requested review from wsxiaoys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangfung @wsxiaoys