feat(chat-panel): add vscode bundle script #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
reviewed
May 21, 2024
Comment on lines
10
to
13
| useEffect(() => { | ||
| if (iframeRef.current && !clientRef.current) { | ||
| if (iframeRef.current && !clientRef.current) | ||
| clientRef.current = createClient(iframeRef.current, api) | ||
| } |
There was a problem hiding this comment.
Please revert the change. always use {} with if except one line ifs.
There was a problem hiding this comment.
update the eslint
export default antfu({
rules: {
curly: ['off', 'all'],
},
})
|
cc @icycodes |
wsxiaoys
approved these changes
May 21, 2024
| @@ -21,7 +20,8 @@ function useServer(api: ServerApi) { | |||
|
|
|||
| useEffect(() => { | |||
| const isInIframe = window.self !== window.top | |||
| if (isInIframe && !serverRef.current) serverRef.current = createServer(api) | |||
| if (isInIframe && !serverRef.current) | |||
| serverRef.current = createServer(api) | |||
There was a problem hiding this comment.
ditto, revert changes to this file since they're all formatting related
There was a problem hiding this comment.
i suggest revert change to this file as they're formatting changes.
There was a problem hiding this comment.
rename this to iframe.tsx, since it's likely reuse by jetbrains as well
wsxiaoys
reviewed
May 21, 2024
| @@ -42,17 +42,21 @@ | |||
| "start": "tsx src/index.ts", | |||
| "test": "vitest", | |||
| "test:once": "vitest run", | |||
| "typecheck": "tsc --noEmit" | |||
| "typecheck": "tsc --noEmit", | |||
| "build:vscode": "yarn && esbuild src/vscode.tsx --bundle --minify --outfile=../vscode/chat-panel/index.js --loader:.js=jsx", | |||
There was a problem hiding this comment.
left a FIXME comment, because I have no idea how to edit the config file, I don't wanna spend time to check this document at the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the VSCode chat panel, we generate a Webview using the following code snippet. It consists of HTML that loads a js script.
Goal
In
clients/tabby-chat-panel, it can generate a bundled JS file used for the VSCode webview.clients/tabby-chat-panel, commandyarn build:vscodewill generate a bundled JS file into clients/vscode/chat-panel/clients/vscode, commandyarn buildwill callclients/tabby-chat-panelto generate the JS file