Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webserver): fix oauth login regression caused by #1452 #1484

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

wsxiaoys
Copy link
Member

No description provided.

@wsxiaoys wsxiaoys requested a review from boxbeam February 19, 2024 00:47
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5c4baec) 48.47% compared to head (be63f7c) 48.53%.
Report is 4 commits behind head on main.

Files Patch % Lines
ee/tabby-webserver/src/oauth/github.rs 0.00% 3 Missing ⚠️
ee/tabby-webserver/src/oauth/google.rs 0.00% 3 Missing ⚠️
ee/tabby-webserver/src/service/dao.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   48.47%   48.53%   +0.06%     
==========================================
  Files         106      107       +1     
  Lines        8271     8330      +59     
==========================================
+ Hits         4009     4043      +34     
- Misses       4262     4287      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys enabled auto-merge (squash) February 19, 2024 00:53
@wsxiaoys wsxiaoys disabled auto-merge February 19, 2024 00:55
ee/tabby-webserver/src/oauth/github.rs Outdated Show resolved Hide resolved
ee/tabby-webserver/src/oauth/google.rs Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys enabled auto-merge (squash) February 19, 2024 17:07
@wsxiaoys wsxiaoys merged commit be1d579 into main Feb 19, 2024
6 of 7 checks passed
@wsxiaoys wsxiaoys deleted the fix-oauth-login branch February 19, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants