Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): support load ca cert from os. #1468

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

icycodes
Copy link
Member

@icycodes icycodes commented Feb 16, 2024

Complete TAB-481
Related #881

Changes:
Added support for load system ca certificates.

[tls]
caCerts = "system" # "bundled" or "system" or a string contains paths to cert files 
  • "bundled"
    Use Node.js bundled default CA certificates. Same as the behavior before this support.
  • "system" (default)
    • Linux: load CA certificates from /etc/ssl/certs/ca-certificates.crt
    • Windows: load CA certificates from Trusted Root Certification Authorities Certificate Store (win-ca)
    • macOS: load CA certificates from Keychain (mac-ca)
  • paths to cert files
    Load CA certificates from the specified paths joined by :. Should work like NODE_EXTRA_CA_CERTS. Could be useful for some Linux systems that do not have the certificates in the common OpenSSL path /etc/ssl/certs/ca-certificates.crt.

@icycodes icycodes marked this pull request as draft February 16, 2024 12:07
@icycodes icycodes force-pushed the feat-agent-support-os-stored-ca branch from 62e44af to ccf0214 Compare February 20, 2024 05:23
@icycodes icycodes marked this pull request as ready for review February 20, 2024 05:46
@wsxiaoys wsxiaoys merged commit d6d4903 into TabbyML:main Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants