feat: Add a new event type:dismiss. Add view_id and elapsed in event body.
#1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this ready for review? |
wsxiaoys
approved these changes
Jan 8, 2024
boxbeam
reviewed
Jan 8, 2024
| @@ -3,14 +3,18 @@ use utoipa::ToSchema; | |||
|
|
|||
| #[derive(Serialize, Deserialize, ToSchema, Clone, Debug)] | |||
| pub struct LogEventRequest { | |||
| /// Event type, should be `view` or `select`. | |||
| /// Event type, should be `view`, `select` or `dismiss`. | |||
There was a problem hiding this comment.
Maybe we should use an enum to model this, or Discriminant<Event>? I believe I forgot to modify this comment when adding the Completion variant - using Discriminant<Event> would make it clear through the type system what this is, and not require updating the comment every time a new event is added.
There was a problem hiding this comment.
there's no need to modify this, completion event are not logged through this route. (they're part of logic in side /completion)
boxbeam
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete TAB-382