feat(ui): add commit hash to attachmentCode for accurate redirection

ee/tabby-ui/app/files/components/source-code-browser.tsx

@@ -192,7 +192,12 @@ const SourceCodeBrowserContextProvider: React.FC<PropsWithChildren> = ({
         })
       } else {
         const setParams: Record<string, string> = {}
-        let delList = ['redirect_filepath', 'redirect_git_url', 'line']
+        let delList = [
+          'redirect_filepath',
+          'redirect_git_url',
+          'redirect_rev',
+          'line'
+        ]
         if (options?.plain) {
           setParams['plain'] = '1'
         } else {
@@ -501,13 +506,19 @@ const SourceCodeBrowserRenderer: React.FC<SourceCodeBrowserProps> = ({
       const repos = await fetchAllRepositories()
       const redirect_filepath = searchParams.get('redirect_filepath')
       const redirect_git_url = searchParams.get('redirect_git_url')
+      const redirect_rev = searchParams.get('redirect_rev')
 
       if (repos?.length && redirect_filepath && redirect_git_url) {
         const targetRepo = repos.find(repo => repo.gitUrl === redirect_git_url)
         if (targetRepo) {
-          // use default rev
-          const defaultRef = getDefaultRepoRef(targetRepo.refs)
-          const refName = resolveRepoRef(defaultRef)?.name || ''
+          let refName = ''
+          if (redirect_rev) {
+            refName = redirect_rev
+          } else {
+            // use default rev
+            const defaultRef = getDefaultRepoRef(targetRepo.refs)
+            refName = resolveRepoRef(defaultRef)?.name || ''
+          }
 
           const lineRangeInHash = parseLineNumberFromHash(window.location.hash)
           const isValidLineHash = !isNil(lineRangeInHash?.start)

ee/tabby-ui/app/search/components/assistant-message-section.tsx

@@ -24,6 +24,7 @@ import {
   RelevantCodeContext
 } from '@/lib/types'
 import {
+  buildCodeBrowserUrlForContext,
   cn,
   formatLineHashForCodeBrowser,
   getContent,
@@ -172,13 +173,14 @@ export function AssistantMessageSection({
           filepath: code.filepath,
           content: code.content,
           git_url: code.gitUrl,
+          commit: code.commit ?? undefined,
           extra: {
             scores: code?.extra?.scores
           }
         }
       }) ?? []
     )
-  }, [clientCode, message?.attachment?.code])
+  }, [message?.attachment?.code])
 
   const messageAttachmentClientCode = useMemo(() => {
     return clientCode?.map(o => ({
@@ -200,18 +202,8 @@ export function AssistantMessageSection({
 
   const onCodeContextClick = (ctx: Context) => {
     if (!ctx.filepath) return
-    const url = new URL(`${window.location.origin}/files`)
-    const searchParams = new URLSearchParams()
-    searchParams.append('redirect_filepath', ctx.filepath)
-    searchParams.append('redirect_git_url', ctx.git_url)
-    url.search = searchParams.toString()
-
-    const lineHash = formatLineHashForCodeBrowser(ctx.range)
-    if (lineHash) {
-      url.hash = lineHash
-    }
-
-    window.open(url.toString())
+    const url = buildCodeBrowserUrlForContext(window.location.origin, ctx)
+    window.open(url, '_blank')
   }
 
   const onCodeCitationMouseEnter = (index: number) => {
@@ -232,6 +224,9 @@ export function AssistantMessageSection({
     const searchParams = new URLSearchParams()
     searchParams.append('redirect_filepath', code.filepath)
     searchParams.append('redirect_git_url', code.gitUrl)
+    if (code.commit) {
+      searchParams.append('redirect_rev', code.commit)
+    }
     url.search = searchParams.toString()
 
     const lineHash = formatLineHashForCodeBrowser(range)

ee/tabby-ui/components/chat/question-answer.tsx

@@ -278,7 +278,8 @@ function AssistantMessageCard(props: AssistantMessageCardProps) {
         range: getRangeFromAttachmentCode(code),
         filepath: code.filepath,
         content: code.content,
-        git_url: code.gitUrl
+        git_url: code.gitUrl,
+        commit: code.commit ?? undefined
       })) ?? []
     )
   }, [message?.relevant_code])

ee/tabby-ui/lib/hooks/use-thread-run.ts

@@ -41,6 +41,7 @@ const CreateThreadAndRunSubscription = graphql(/* GraphQL */ `
         hits {
           code {
             gitUrl
+            commit
             filepath
             language
             content
@@ -118,6 +119,7 @@ const CreateThreadRunSubscription = graphql(/* GraphQL */ `
         hits {
           code {
             gitUrl
+            commit
             filepath
             language
             content

ee/tabby-ui/lib/tabby/query.ts

@@ -402,6 +402,7 @@ export const listThreadMessages = graphql(/* GraphQL */ `
           attachment {
             code {
               gitUrl
+              commit
               filepath
               language
               content

ee/tabby-ui/lib/types/chat.ts

@@ -19,6 +19,7 @@ export interface FileContext {
   range?: { start: number; end: number }
   content: string
   git_url: string
+  commit?: string
 }
 
 export type Context = FileContext

ee/tabby-ui/lib/utils/index.ts

@@ -269,6 +269,10 @@ export function buildCodeBrowserUrlForContext(
   const searchParams = new URLSearchParams()
   searchParams.append('redirect_filepath', context.filepath)
   searchParams.append('redirect_git_url', context.git_url)
+  if (context.commit) {
+    searchParams.append('redirect_rev', context.commit)
+  }
+
   url.search = searchParams.toString()
 
   url.hash = formatLineHashForCodeBrowser(context.range)