fixme comment for tmp solution

TabbyML · May 24, 2024 · 1eec0ec · 1eec0ec
1 parent de39118
commit 1eec0ec
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/clients/vscode/src/ChatViewProvider.ts b/clients/vscode/src/ChatViewProvider.ts
@@ -4,6 +4,7 @@ import { ServerApi, ChatMessage, Context } from "tabby-chat-panel";
 import { agent } from "./agent";
 import { createClient } from "./chatPanel";
 
+// FIXME(wwayne): Example code has webview removed case, not sure when it would happen, need to double check
 export class ChatViewProvider implements WebviewViewProvider {
   webview?: WebviewView;
   client?: ServerApi;

diff --git a/clients/vscode/src/chatPanel.ts b/clients/vscode/src/chatPanel.ts
@@ -16,6 +16,7 @@ export function createThreadFromWebview<Self = Record<string, never>, Target = R
           listen(data);
         });
 
+        // FIXME(wwayne): double check if the connection got any edge cases
         signal?.addEventListener("abort", () => {
           dispose();
         });

diff --git a/ee/tabby-ui/app/chat/page.tsx b/ee/tabby-ui/app/chat/page.tsx
@@ -7,7 +7,6 @@ import { useSearchParams } from 'next/navigation'
 
 import { nanoid } from '@/lib/utils'
 import { Chat, ChatRef } from '@/components/chat/chat'
-import { QuestionAnswerPair } from '@/lib/types/chat'
 import Color from 'color'
 
 import './page.css'
@@ -33,9 +32,8 @@ export default function ChatPage() {
     null
   )
   const [activeChatId, setActiveChatId] = useState('')
-  const [initialMessages, setInitialMessages] = useState<QuestionAnswerPair[]>(
-    []
-  )
+  let pendingMessages: ChatMessage[] = [] // FIXME(wwayne): use init message props after Chat component update
+
   const chatRef = useRef<ChatRef>(null)
   const searchParams = useSearchParams()
   const maxWidth = searchParams.get('max-width') || undefined
@@ -71,14 +69,7 @@ export default function ChatPage() {
     if (chatRef.current) {
       chatRef.current.sendUserChat(message)
     } else {
-      const newInitialMessages = [...initialMessages]
-      newInitialMessages.push({
-        user: {
-          ...message,
-          id: nanoid()
-        }
-      })
-      setInitialMessages(newInitialMessages)
+      pendingMessages.push(message)
     }
   }
 
@@ -88,6 +79,11 @@ export default function ChatPage() {
       setActiveChatId(nanoid())
       setIsInit(true)
       setFetcherOptions(request.fetcherOptions)
+
+      // FIXME(wwayne): This is no needed after Chat support initMessage
+      setTimeout(() => {
+        pendingMessages.forEach(sendMessage)
+      }, 1000)
     },
     sendMessage: (message: ChatMessage) => {
       return sendMessage(message)
@@ -108,7 +104,6 @@ export default function ChatPage() {
       key={activeChatId}
       ref={chatRef}
       headers={headers}
-      initialMessages={initialMessages}
       onThreadUpdates={() => {}}
       onNavigateToContext={onNavigateToContext}
       maxWidth={maxWidth}