BaseGrid __eq__ method no longer uses elementwise comparison #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If grids are not equal, numpy throws a Deprecation warning for elementwise comparison: ``` /home/charriso/micromamba/envs/ascat_env/lib/python3.8/site-packages/numpy/ma/core.py:4123: DeprecationWarning: elementwise comparison failed; this will raise an error in the future. check = compare(sdata, odata) ``` Using np.array_equal(arr1, arr2) rather than np.all(arr1==arr2) should fix this
|
Thanks, I will just close and re-open this to check if the tests still pass. |
|
Let me (or @sebhahn) know if you lack any permissions for any of the repositories you work on. We can make a new pypi release any time if you want. |
|
Thanks! And yeah, I need to check equality on grids for some updates to the ascat package, so it would be useful to have this change in the pypi version. I just realized I need to also change this for CellGrid so I'll submit another PR for that shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If grids are not equal, numpy throws a Deprecation warning for elementwise comparison:
Using np.array_equal(arr1, arr2) rather than np.all(arr1==arr2) should fix this