Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 support/fixed signal when using @transaction because of session.beg… #135

Merged
merged 2 commits into from
May 18, 2022

Conversation

TTWShell
Copy link
Owner

flask-sqlalchemy signal在nested transaction下的bug: pallets-eco/flask-sqlalchemy#645

@TTWShell TTWShell force-pushed the bugfix/nested-session-signals branch 5 times, most recently from 00db5bd to 6d9f636 Compare May 18, 2022 08:26
…lling support is unavailable because the blinker library is not installed)
@TTWShell TTWShell force-pushed the bugfix/nested-session-signals branch from 6d9f636 to 80fc5cc Compare May 18, 2022 08:38
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #135 (80fc5cc) into master (65e60b5) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   97.83%   97.92%   +0.08%     
==========================================
  Files          28       28              
  Lines        1203     1254      +51     
==========================================
+ Hits         1177     1228      +51     
  Misses         26       26              
Impacted Files Coverage Δ
hobbit_core/db.py 99.11% <100.00%> (+0.01%) ⬆️
tests/test_app/models.py 100.00% <100.00%> (ø)
tests/test_app/run.py 100.00% <100.00%> (ø)
tests/test_app/views.py 96.15% <100.00%> (+2.60%) ⬆️
tests/test_db.py 99.56% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e60b5...80fc5cc. Read the comment docs.

@TTWShell TTWShell merged commit 959099f into master May 18, 2022
@TTWShell TTWShell deleted the bugfix/nested-session-signals branch May 18, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant