Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sonarr): German Sonarr Guide #2202

Merged
merged 20 commits into from
Jan 13, 2025

Conversation

Lokilicious
Copy link
Contributor

@Lokilicious Lokilicious commented Jan 4, 2025

Pull Request

Purpose

We want to provide a German Sonarr Guide based on constraints and use-cases of the German community.

Approach

Create a Sonarr Guide

Open Questions and Pre-Merge TODOs

Migrate existing CFs to Sonarr (ensure compatibility and update hashes - prefix Sonarr to create unique hashes)

  • German DL
  • German DL (undefined)
  • German
  • German WEB Tier 01
  • German WEB Tier 02
  • German WEB Tier 03
  • German Bluray Tier 01
  • German Bluray Tier 02
  • German Bluray Tier 03
  • German Remux Tier 01
  • German Remux Tier 02
  • German Scene
  • German 1080p Booster
  • German 2160p Booster
  • German LQ
  • German Microsized

Profiles to be included:

  • HD Bluray + WEB
  • HD Remux + WEB
  • UHD Bluray + WEB (2160p) & Alternative (720p > 1080p > 2160p)
  • UHD Remux + WEB

Other

  • Write the Guide
  • Add CF to collection of CFs and fix links
  • Add Remux CFs to collection of CFs
  • Add TSCC to Remux Tier

Requirements

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Backend Backend Changes, not related to a specific section labels Jan 4, 2025
@github-actions github-actions bot added the Area: Starr Custom Formats Issue is related to custom formats label Jan 4, 2025
@jonasriecken
Copy link

German DL is missing
@Lokilicious

@Lokilicious
Copy link
Contributor Author

German DL is missing @Lokilicious

@jonasriecken German DL was already merged in the past, so you are right that its not part of this changeset :)

@Lokilicious Lokilicious requested review from PCJones and TRaSH- January 7, 2025 07:49
@Lokilicious Lokilicious marked this pull request as ready for review January 7, 2025 07:49
@TRaSH- TRaSH- self-assigned this Jan 7, 2025
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Jan 9, 2025
@TRaSH- TRaSH- removed the Status: Conflicted Pull Request is Conflicted label Jan 9, 2025
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started Review, Hope to finish it tomorrow when I get back from home from work

Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Radarr CF for the German Bluray Tier 01, 02, and 03' has the No Remuxcondition added. Did you test whether it's also needed for the Sonarr one? Also, we use the release group condition"value": "^(RlsGrp)$"and we noticed that the German ones use"value": "(RlsGrp)$"`

@Lokilicious Lokilicious marked this pull request as draft January 12, 2025 11:23
@github-actions github-actions bot added the Area: Radarr Radarr Related label Jan 12, 2025
@Lokilicious Lokilicious marked this pull request as ready for review January 12, 2025 17:58
@Lokilicious Lokilicious requested a review from TRaSH- January 13, 2025 10:25
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no issues

@TRaSH- TRaSH- merged commit ad91473 into TRaSH-Guides:master Jan 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants