Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arbitrary OPTS to env.sh #899

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

PACordonnier
Copy link
Member

@PACordonnier PACordonnier commented Dec 13, 2024

Which issue(s) this PR fixes

Partially fixes #898

Additional comments

In order to add garbage collect configuration to hadoop daemon (required in #898), it is needed to add custom *_OPTS to daemon e.g: -XX:PermSize=512m -XX:+UseG1GC -XX:MaxGCPauseMillis=4000 -XX:ParallelGCThreads=20 -XX:ConcGCThreads=5 -XX:InitiatingHeapOccupancyPercent=70 need to be added to HADOOP_NAMENODE_OPTS.

The PR adds to templates hadoop-env.sh, hbase-env.sh and hive-env.sh a way to add arbitrary JVM opts to the hadoop client, HDFS client, namenode, datanode, journalnode, YARN resourcemanager, nodemanager, timelineserver, mapred historyserver, HIVE client, hiveserver2 and metastore.

Agreements

@PACordonnier
Copy link
Member Author

Some double quotes are missing

Switch position to have tdp customs at the end

@PACordonnier PACordonnier force-pushed the 898-garbage-collect-configuration branch 2 times, most recently from f825187 to 408f7b1 Compare December 13, 2024 14:30
@PACordonnier
Copy link
Member Author

PACordonnier commented Dec 13, 2024

Some double quotes are missing

Switch position to have tdp customs at the end

Done in latest force push

Also added HTTPfs in opts

@PACordonnier PACordonnier force-pushed the 898-garbage-collect-configuration branch from 408f7b1 to 3838e92 Compare December 17, 2024 13:50
@PACordonnier
Copy link
Member Author

Fix typo (hdfs_namenodenode_custom_opts to hdfs_namenode_custom_opts) in latest force push

@PACordonnier PACordonnier force-pushed the 898-garbage-collect-configuration branch from 3838e92 to eab480e Compare December 19, 2024 09:43
@PACordonnier
Copy link
Member Author

Added phoenix queryserver hbase-env.sh in latest force push

@PACordonnier PACordonnier force-pushed the 898-garbage-collect-configuration branch from eab480e to 77a418c Compare December 19, 2024 09:51
@PACordonnier
Copy link
Member Author

change variable names and opts name in latest force push

@rpignolet rpignolet merged commit bc7a365 into master Dec 20, 2024
3 checks passed
@rpignolet rpignolet deleted the 898-garbage-collect-configuration branch December 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Garbage collect configuration
2 participants