Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ranger): add whitespace in order to fix templating #855

Closed
wants to merge 1 commit into from

Conversation

PACordonnier
Copy link
Member

@PACordonnier PACordonnier commented Jul 9, 2024

Which issue(s) this PR fixes

Missing whitespace in install.properties.j2 create issue when ranger templates its site.

Heres an example of what the property is templated to in ranger-admin-site.xml by ranger's setup.sh

        <property>
                <name>ranger.spnego.kerberos.keytab</name>
                <value>/etc/security/keytabs/spnego.service.keytabtoken_valid=30</value>
        </property>

You can see that this small unfortunate mistake has been introduced by #844 here https://github.com/TOSIT-IO/tdp-collection/pull/844/files#diff-5d5bf852121faeb978b8b79af8454dea1115d35aae78b1803acd53e1608a44d9

Agreements

@PACordonnier PACordonnier requested a review from mehdibn July 9, 2024 15:39
@rpignolet
Copy link
Contributor

Maybe resolve with #852

@rpignolet
Copy link
Contributor

#852 is merged. Still relevant ?

@PACordonnier
Copy link
Member Author

Fixed by #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants