Skip to content

Commit

Permalink
fix: ansible.builtin.copy dest should specify full filename
Browse files Browse the repository at this point in the history
  • Loading branch information
giem-git committed Sep 3, 2024
1 parent b2a3d19 commit 8e16db3
Show file tree
Hide file tree
Showing 19 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion roles/exporter/jmx/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
- name: Upload jmx-exporter jar
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ jmx_exporter_dist_file }}"
dest: "{{ jmx_exporter_root_dir }}"
dest: "{{ jmx_exporter_root_dir }}/{{ jmx_exporter_dist_file }}"
group: root
owner: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hadoop/common/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
- name: Upload {{ hadoop_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ hadoop_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ hadoop_dist_file }}"
group: root
owner: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hbase/common/tasks/install_hbase.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
- name: Upload {{ hbase_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ hbase_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ hbase_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hbase/common/tasks/install_phoenix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ phoenix_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ phoenix_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ phoenix_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hbase/phoenix/queryserver/common/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
- name: Upload {{ phoenix_queryserver_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ phoenix_queryserver_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ phoenix_queryserver_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hbase/ranger/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ ranger_hbase_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_hbase_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_hbase_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hdfs/ranger/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ ranger_hdfs_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_hdfs_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_hdfs_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hive/common/tasks/hdfs_init.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
- name: Upload {{ tez_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ tez_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ tez_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
4 changes: 2 additions & 2 deletions roles/hive/common/tasks/install_hive.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ hive_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ hive_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ hive_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down Expand Up @@ -70,7 +70,7 @@
- name: Upload {{ tez_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ tez_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ tez_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/hive/ranger/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ ranger_hive_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_hive_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_hive_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
8 changes: 4 additions & 4 deletions roles/knox/common/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@

- name: Upload Knox binaries
ansible.builtin.copy:
src: "{{ item }}"
dest: "{{ binaries_upload_dir }}"
src: "{{ binaries_local_dir }}/{{ item }}"
dest: "{{ binaries_upload_dir }}/{{ item }}"
owner: root
group: root
mode: "644"
loop:
- "{{ binaries_local_dir }}/{{ knox_dist_file }}"
- "{{ binaries_local_dir }}/{{ knoxshell_dist_file }}"
- "{{ knox_dist_file }}"
- "{{ knoxshell_dist_file }}"
diff: false

- name: Ensure {{ knox_root_dir }} exists
Expand Down
2 changes: 1 addition & 1 deletion roles/knox/ranger/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ ranger_knox_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_knox_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_knox_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/ranger/admin/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
- name: Upload {{ ranger_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/ranger/kms/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
- name: Upload {{ ranger_kms_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_kms_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_kms_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
4 changes: 2 additions & 2 deletions roles/ranger/solr/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
- name: Upload {{ solr_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ solr_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ solr_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down Expand Up @@ -113,7 +113,7 @@
- name: Upload solr bootstrap configuration files
ansible.builtin.copy:
src: "{{ item }}"
dest: "{{ solr_bootstrap_config_dir }}"
dest: "{{ solr_bootstrap_config_dir }}/{{ item }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/ranger/usersync/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
- name: Upload {{ ranger_usersync_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_usersync_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_usersync_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/spark/common/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ spark_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ spark_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ spark_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/yarn/ranger/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- name: Upload {{ ranger_yarn_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ ranger_yarn_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ ranger_yarn_dist_file }}"
owner: root
group: root
mode: "644"
Expand Down
2 changes: 1 addition & 1 deletion roles/zookeeper/common/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
- name: Upload {{ zookeeper_dist_file }}
ansible.builtin.copy:
src: "{{ binaries_local_dir }}/{{ zookeeper_dist_file }}"
dest: "{{ binaries_upload_dir }}"
dest: "{{ binaries_upload_dir }}/{{ zookeeper_dist_file }}"
group: root
owner: root
mode: "644"
Expand Down

0 comments on commit 8e16db3

Please sign in to comment.