Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check debug messages during blocking RFC call #249

Open
tolauwae opened this issue Jul 27, 2024 · 0 comments
Open

Check debug messages during blocking RFC call #249

tolauwae opened this issue Jul 27, 2024 · 0 comments
Assignees
Labels
major feature A major feature or breaking change question Further information is requested

Comments

@tolauwae
Copy link
Member

tolauwae commented Jul 27, 2024

For PR #238 we allowed checking debug messages during blocking RFC calls.

There is an issue with the supervisor and the proxy RFC calls. Because they are synchronous, they hijack the main interpretation loop. The loop does not advance as it waits for the proxy call to finish, this is inline with our "atomic" design of primitives, no debug messages are processed during their execution.

In this case we do want this, since during the proxy call, the proxy device will send back debug messages.

This was changed in 34b89fd.

Problem: However, we might not want to process just any debug message. What if we send a RUN command? This would break everything catastrophically.

@tolauwae tolauwae added question Further information is requested major feature A major feature or breaking change labels Jul 27, 2024
@tolauwae tolauwae self-assigned this Jul 27, 2024
@tolauwae tolauwae moved this to In Progress in WARDuino Roadmap Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major feature A major feature or breaking change question Further information is requested
Projects
Status: In Progress
Development

No branches or pull requests

1 participant