Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔬 memory primitive prototype #238

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

🔬 memory primitive prototype #238

wants to merge 14 commits into from

Conversation

tolauwae
Copy link
Member

@tolauwae tolauwae commented Apr 3, 2024

No description provided.

@tolauwae tolauwae added the experimental Experimental feature/branch label Apr 3, 2024
@tolauwae
Copy link
Member Author

tolauwae commented Apr 3, 2024

There is an issue with the supervisor and the proxy RFC calls. Because they are synchronous, they hijack the main interpretation loop. The loop does not advance as it waits for the proxy call to finish, this is inline with our "atomic" design of primitives, no debug messages are processed during their execution.

In this case we do want this, since during the proxy call, the proxy device will send back debug messages.

@tolauwae tolauwae force-pushed the feat/memory-primitive-prototype branch 2 times, most recently from 6ff87e0 to 3396bd8 Compare April 3, 2024 12:41
@tolauwae
Copy link
Member Author

tolauwae commented Apr 3, 2024 •
edited
Loading

There is an issue with the supervisor and the proxy RFC calls. Because they are synchronous, they hijack the main interpretation loop. The loop does not advance as it waits for the proxy call to finish, this is inline with our "atomic" design of primitives, no debug messages are processed during their execution.

In this case we do want this, since during the proxy call, the proxy device will send back debug messages.

Changed in 34b89fd

However, we might not want to process just any debug message. What if we send a RUN command? This would break everything catastrophically. see #249

@tolauwae tolauwae mentioned this pull request Jul 27, 2024
Open
@tolauwae
Copy link
Member Author

Fixes #78

@tolauwae tolauwae changed the title Feat/memory primitive prototype 🔬 memory primitive prototype Sep 29, 2024
@tolauwae tolauwae force-pushed the feat/memory-primitive-prototype branch 3 times, most recently from 9ea0587 to c106bf9 Compare November 26, 2024 12:59
@tolauwae tolauwae force-pushed the feat/memory-primitive-prototype branch 2 times, most recently from 3c30dd0 to f683c8d Compare November 26, 2024 13:05
@tolauwae tolauwae force-pushed the feat/memory-primitive-prototype branch from dadb940 to cd34802 Compare November 27, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experimental Experimental feature/branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tolauwae