Feature/prefilling fields #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev to main
…omized HermesDataConverter class.
jchate6
requested changes
Oct 9, 2024
added 3 commits
October 11, 2024 21:51
…TNS, and only add in telescope field if reduced datum is selected for TNS form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the prefilling of fields in the tom_tns forms to use the new HermesDataConverter class. It also allows prefilling many more of the fields in the form then was previously available. This should aid users in being able to fill out the form faster and not have to refill out information that is already in their TOM models somewhere. It also includes the "telescope" in the hermes submitted TNS message if it is present in the data, and lets users configure the mapping of datum instruments to TNS instruments.