Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Fink livestreams #24

Closed
wants to merge 4 commits into from
Closed

Handle Fink livestreams #24

wants to merge 4 commits into from

Conversation

JulienPeloton
Copy link
Collaborator

This PR adds new classes to manipulate Fink livestreams (in addition to data coming from the REST API):

  • add a Query form (FinkDESCQueryForm)
  • add a class to handle livestream (FinkDESC)
  • add a method to fetch alerts using the fink-client consumer FinkDESC.fetch_alerts
  • add a method to translate data for TOM FinkDESC.to_generic_alert
  • update the test suite
  • TBC...

@dmcollom
Copy link
Contributor

Hi @JulienPeloton -- my apologies for the delay. I actually left LCO in September, but I'm trying to stay involved with the project as best I can in my spare time.

Things look good, but it looks like there are some syntax errors in the widget definitions for the new form that need to be cleaned up. I would do it, but I'm not entirely sure what's intended in terms of label vs. display name vs. something else.

The other thing I would note is that the README should be updated with some information about the additional broker option, as well as how to install it into settings.py.

@JulienPeloton
Copy link
Collaborator Author

Hi @dmcollom -- thanks for following up. Actually, I still have code to push before review. I'll let you know when code is ready (no rush though!)

@phycodurus phycodurus self-assigned this Oct 31, 2022
@jchate6 jchate6 self-assigned this Mar 10, 2023
@jchate6
Copy link
Contributor

jchate6 commented Mar 13, 2023

@JulienPeloton any updates on the status of this?

@JulienPeloton
Copy link
Collaborator Author

superseded by #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Services Data Services livestreams User Issue Raised by a user
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants