-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to navaigate to specific tab in target view. #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like these features, and I think this new functionality is fantastic, but I don't see how this directly addresses Issue #697.
The active tab information is still lost on refresh, correct?
Does this functionality override that issue, or should the issue persist once this PR is merged?
tom_observations/templates/tom_observations/partials/observation_list.html
Outdated
Show resolved
Hide resolved
@jchate6 , you've raised a valid point. The problem still persists, as this PR provides enhancements, but doesn't address the original issue. I've given this some thought and have something. I do want to avoid local storage because I don't want the tab to persist upon navigating away.
Our URLs would look like
Thoughts? I will push this to this PR first thing next week along with your comment being addressed. |
Avoiding local storage makes a lot of sense. |
@jchate6 Comments have been addressed and tab is remembered on reload. |
Thanks @davner! I probably won't get to this until Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
Thanks for this @davner.
I think we'll probably want to take some time in the future changing redirects and maybe adding a default option to settings.py
so users can choose their default landing page for their TOM. Very exciting.
@jchate6 Not a problem. I'm trying to push back all the changes I make for our project that would be beneficial to all users. Glad you like this one! |
Resolves Issue #697.
Introduces URL parameter support for directly navigating to specific tabs in the target detail view (e.g.,
/targets/1/?tab=observations
). Initial implementation is limited to two sections that our users found most impactful but could be applied anywhere the directs to the target detail view. This was written with vanilla javascript, removing the concern of Jquery conflicts.Augments
observation_list.html
to display observation IDs, improving user experience to trace data to what ID in the overview.