Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove reliance on alerce page return #692

Merged
merged 4 commits into from
Oct 3, 2023
Merged

remove reliance on alerce page return #692

merged 4 commits into from
Oct 3, 2023

Conversation

jchate6
Copy link
Contributor

@jchate6 jchate6 commented Sep 27, 2023 •
edited
Loading

This change removes the reliance on the page key being returned successfully from the broker. We rely entirely on our own pagination count.
This Key is returned null for all requests from ALeRCE.

@jchate6 jchate6 requested a review from phycodurus September 27, 2023 12:43
@jchate6 jchate6 linked an issue Sep 27, 2023 that may be closed by this pull request
Error in Alerce Alert Cone search #691
Closed
@jchate6 jchate6 added bug Something isn't working Data Services Data Services labels Sep 27, 2023
@jchate6 jchate6 merged commit 4ca74b0 into dev Oct 3, 2023
22 checks passed
@jchate6 jchate6 deleted the fix/error-in-alerce-alert-cone-search branch October 3, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phycodurus phycodurus phycodurus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Data Services Data Services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in Alerce Alert Cone search
2 participants
@jchate6 @phycodurus