Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/more docs #273

Merged
merged 9 commits into from
Jan 19, 2022
Merged

Feature/more docs #273

merged 9 commits into from
Jan 19, 2022

Conversation

dmcollom
Copy link
Contributor

In addition to addressing #271 and #272, this adds a blurb about writing tests to the FAQ doc.

jfrostburke
jfrostburke approved these changes Apr 18, 2020
View reviewed changes
Copy link
Collaborator

@jfrostburke jfrostburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a TNS API key and targets import correctly.

@dmcollom
Copy link
Contributor Author

Tested with a TNS API key and targets import correctly.

Did you test the harvester or the broker? The change was to the broker.

@jfrostburke
Copy link
Collaborator

Ah good catch, I was testing the harvester. When I test the broker it does not work, I get a 403 Client Error: Forbidden for url: https://wis-tns.weizmann.ac.il/api/get/api/get/search. I get the same error regardless of what field I query on -- object name, cone search, or discovery date. I'll send you the API key so it's easier for you to test.

@dmcollom dmcollom changed the base branch from development to dev March 10, 2021 23:04
@dmcollom
Copy link
Contributor Author

dmcollom commented Nov 1, 2021

@phycodurus Since Austin fixed the TNS broker and I just merged in dev, this should be ready to merge.

@phycodurus phycodurus merged commit 15d6115 into dev Jan 19, 2022
@phycodurus phycodurus deleted the feature/more_docs branch January 25, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrostburke jfrostburke jfrostburke approved these changes

@phycodurus phycodurus phycodurus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmcollom @jfrostburke @phycodurus