Add in persistentshare model and views and hook it into the target sh…

[jnation3406]

…are page.

There are so many urls added since I added both API views with django rest framework, and template / management views for normal tom users. The template views use the DRF views to actually create/delete persistentshare instances. There is also a version of URLS that applies to all targets, vs one filtered on a specific target for both creation and management. I tried to get permissions such that only a user with target_share permissions and permissions on that specific target should be able to create a persistent share on that target.

Screencast.from.2024-12-10.06-39-48.webm

[jchate6]

Only part of the way through the review. Will try to finish tomorrow.

[jchate6]

Some more things...

[jnation3406]

I re-did the permissions and removed the share_target permission everywhere. Now its all using the change_target permissions + the persistentshare permissions. I also updated the pages to show/hide stuff based on your users permissions.

This is when you only have view_persistentshare permissions + target permissions

This is view + delete:

And this is view + delete + add (basically all permissions, change isn't used since they can't be modified):

[jchate6]

The permissions changes seem to work really well.
Will deleting the user who made a persistent share have any unforeseen repercussions? It doesn't look like there are any immediate problems, but I haven't tested actually triggering a share.

[jnation3406]

The permissions changes seem to work really well. Will deleting the user who made a persistent share have any unforeseen repercussions? It doesn't look like there are any immediate problems, but I haven't tested actually triggering a share.

It shouldn't have any effect. Anyone with permissions can see/delete any persistent shares, the user that created it is just for knowledge purposes to know who you can ask for why they did that in your collaboration.

[jchate6]

I get an error when I try to add a persistent share via the admin interface:
TypeError: BaseModelForm.__init__() got an unexpected keyword argument 'user'

[jnation3406]

I get an error when I try to add a persistent share via the admin interface: TypeError: BaseModelForm.__init__() got an unexpected keyword argument 'user'

Oops I had broken that when changing the forms before. It's fixed now.

[jchate6]

Looks good!