Fix Basename Parsing in Router Registration Method #1123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the register method of the custom
SharedAPIRootRouter
class, where thebasename
was not being correctly parsed due to an error in the logical expression’s precedence. This led to thebasename
being incorrectly set toNone
. This was discovered due to our tom crashing in cases whereviewsets
do not have a queryset to fall back on for defaultbasename
generation.With the fix
Without the fix