Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1019 add moon to aladin sky chart on target list page #1118

Merged
merged 21 commits into from
Dec 5, 2024
Merged

1019 add moon to aladin sky chart on target list page #1118

merged 21 commits into from
Dec 5, 2024

Conversation

phycodurus
Copy link
Contributor

Sending you this draft PR to keep you in the loop.

@phycodurus phycodurus requested a review from jchate6 November 13, 2024 23:56
@phycodurus phycodurus linked an issue Nov 13, 2024 that may be closed by this pull request
Add Moon to Aladin Sky chart on Target List Page #1019
Closed
@phycodurus phycodurus self-assigned this Nov 13, 2024
@phycodurus phycodurus marked this pull request as ready for review November 15, 2024 00:55
@phycodurus
Copy link
Contributor Author

This is ready for review now.

  1. Uses Astropy for Sun, Moon position and Astroplan for Moon illumination
  2. Sun, Moon data passed from inclusion tag to template via context
  3. Moon icon greyscale is a function of Moon illumination
  4. Also refactored Targets to be in a single Aladin catalog (vs. each target in its own catalog)

Looks like this:
image

jchate6
jchate6 requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few strong opinions about colors and symbol sizes that I think should be changed.

I also went ahead and just added the phase icons rather than making another 0 priority story to be lost in the icebox for years.

tom_targets/templates/tom_targets/partials/aladin_skymap.html Outdated Show resolved Hide resolved
tom_targets/templates/tom_targets/partials/aladin_skymap.html Show resolved Hide resolved
tom_targets/templates/tom_targets/partials/aladin_skymap.html Outdated Show resolved Hide resolved
@phycodurus phycodurus requested a review from jchate6 November 20, 2024 00:18
jchate6
jchate6 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

jchate6
jchate6 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things we discussed. Let me know if you'd like me to make these changes.

tom_targets/templates/tom_targets/partials/aladin_skymap.html Show resolved Hide resolved
tom_targets/templates/tom_targets/partials/aladin_skymap.html Outdated Show resolved Hide resolved
@jchate6 jchate6 merged commit 85d5158 into dev Dec 5, 2024
24 checks passed
@jchate6 jchate6 deleted the 1019-add-moon-to-aladin-sky-chart-on-target-list-page branch December 5, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchate6 jchate6 jchate6 approved these changes

Assignees

@phycodurus phycodurus

Labels
None yet
Projects
TOM Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Moon to Aladin Sky chart on Target List Page
2 participants
@phycodurus @jchate6