55 management of application settings #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhrt04
changed the title
rhrt04
changed the title
|
Initial Design
Updated - 05.10.2020 Updated - 20.10.2020 |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
============================================
+ Coverage 78.87% 79.00% +0.12%
- Complexity 316 322 +6
============================================
Files 105 108 +3
Lines 1671 1762 +91
Branches 100 110 +10
============================================
+ Hits 1318 1392 +74
- Misses 317 328 +11
- Partials 36 42 +6
Continue to review full report at Codecov.
|
|
…ved settings that not yet necessary.
…t, Added permission check for update settings method
SamuelWei
requested changes
Oct 16, 2020
…ddleware for update settings and changed select to number input form.
…nt-of-application-settings
SamuelWei
requested changes
Oct 29, 2020
…management-of-application-settings
…b.com/THM-Health/PILOS into 55-management-of-application-settings
SamuelWei
requested changes
Nov 9, 2020
SamuelWei
approved these changes
Nov 23, 2020
|
@dennis95stumm I changed a few files and I'm fine with this PR. Could you please also review it, thanks! |
dsst95
suggested changes
Nov 24, 2020
…M-Health/PILOS into 55-management-of-application-settings
dsst95
suggested changes
Nov 25, 2020
dsst95
reviewed
Dec 1, 2020
dsst95
approved these changes
Dec 1, 2020
…nt-of-application-settings # Conflicts: # CHANGELOG.md # resources/js/lang/de/app.js # resources/js/lang/de/settings.js # resources/js/lang/en/app.js # resources/js/lang/en/settings.js # resources/js/router.js # resources/js/views/settings/roles/Index.vue # tests/Frontend/Router.spec.js
…nt-of-application-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
Type (Highlight the corresponding type)
Checklist
Changes
settings.updateandsettings.viewAny.viewAnyandupdatemethods.updateSettingsto update application settings.Other information